Bug 35272 - Add padding above vendor contracts section
Summary: Add padding above vendor contracts section
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 33798
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-06 20:07 UTC by Caroline Cyr La Rose
Modified: 2023-11-14 15:16 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06


Attachments
Bug 35272: Add padding above vendor contracts section (2.54 KB, patch)
2023-11-07 12:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35272: Add padding above vendor contracts section (2.61 KB, patch)
2023-11-07 14:16 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35272: Add padding above vendor contracts section (2.67 KB, patch)
2023-11-07 21:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-11-06 20:07:06 UTC
This is very minor. I noticed that when a vendor has contracts, the space between the contracts section and the other sections disappeared.

Here is what it looked like https://koha-community.org/manual/23.05/en/html/_images/vendorpage.png

And this is what I currently have: https://snipboard.io/pTKWIA.jpg

Notice how there is no more grey section between the ordering information section and the contracts section.

To recreate:
1. If needed, create a vendor
   1.1. Go to Acquisitions > New vendor
   1.2. Fill out the form, including the contacts section
   1.3. Click Save
2. Create a contract
   2.1. Click New > Contract
   2.2. Fill out the form
   2.3. Click Save
--> Notice there is no space between ordering information and contracts
Comment 1 Owen Leonard 2023-11-07 12:08:52 UTC
Created attachment 158594 [details] [review]
Bug 35272: Add padding above vendor contracts section

This patch makes minor updates to the CSS and markup of the vendor
detail page so that the different page sections have the correct
margins.

To test, apply the patch and rebuild the staff interface CSS.

- In Acquisitions, locate a vendor and add at least one contract if
  necessary.
- View the vendor details page. Each section (Vendor details, Ordering
  information, Contracts) should have comfortable and consistent
  margins.
Comment 2 Caroline Cyr La Rose 2023-11-07 14:16:45 UTC
Created attachment 158600 [details] [review]
Bug 35272: Add padding above vendor contracts section

This patch makes minor updates to the CSS and markup of the vendor
detail page so that the different page sections have the correct
margins.

To test, apply the patch and rebuild the staff interface CSS.

- In Acquisitions, locate a vendor and add at least one contract if
  necessary.
- View the vendor details page. Each section (Vendor details, Ordering
  information, Contracts) should have comfortable and consistent
  margins.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2023-11-07 14:17:14 UTC
Thanks Owen!
Comment 4 Katrin Fischer 2023-11-07 21:39:47 UTC
Created attachment 158625 [details] [review]
Bug 35272: Add padding above vendor contracts section

This patch makes minor updates to the CSS and markup of the vendor
detail page so that the different page sections have the correct
margins.

To test, apply the patch and rebuild the staff interface CSS.

- In Acquisitions, locate a vendor and add at least one contract if
  necessary.
- View the vendor details page. Each section (Vendor details, Ordering
  information, Contracts) should have comfortable and consistent
  margins.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-11-08 13:00:22 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-11-10 08:10:22 UTC
Pushed to 23.05.x for 23.05.06