If you have a patron attribute which is editable in the OPAC (and not tied to an authorized value) there is a "Clear" link by each attribute's <textarea>. It is supposed to clear any content from the text area but it doesn't work.
Created attachment 158609 [details] [review] Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected.
Created attachment 158618 [details] [review] Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 158623 [details] [review] Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.06
Nice work everyone! Pushed to 22.11.x for next release