Bug 35280 - OPAC patron entry form: Patron attributes "clear" link broken
Summary: OPAC patron entry form: Patron attributes "clear" link broken
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-07 17:06 UTC by Owen Leonard
Modified: 2023-11-14 14:50 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form (2.04 KB, patch)
2023-11-07 17:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form (2.09 KB, patch)
2023-11-07 20:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form (2.14 KB, patch)
2023-11-07 21:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-07 17:06:38 UTC
If you have a patron attribute which is editable in the OPAC (and not tied to an authorized value) there is a "Clear" link by each attribute's <textarea>. It is supposed to clear any content from the text area but it doesn't work.
Comment 1 Owen Leonard 2023-11-07 17:18:44 UTC
Created attachment 158609 [details] [review]
Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form

This patch makes a minor correction to the JavaScript controlling the
behavior of the "clear" link which appears on the patron entry form next
to patron attribute <select>s or <textarea>s which are editable in the
OPAC.

To test, apply the patch and create patron attributes
which have both "Display in OPAC" and "Editable in OPAC" checked.

- Create one which is tied to an authorized value, and one which isn't.
- Log in to the OPAC and click the "Personal details" tab.
- In the entry form, find the patron attribute fields under the
  Additional information" heading..
- Select a value in the dropdown, and enter text in the textarea.
- Confirm that clicking the corresponding "Clear" link for each works as
  expected.
Comment 2 David Nind 2023-11-07 20:06:28 UTC
Created attachment 158618 [details] [review]
Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form

This patch makes a minor correction to the JavaScript controlling the
behavior of the "clear" link which appears on the patron entry form next
to patron attribute <select>s or <textarea>s which are editable in the
OPAC.

To test, apply the patch and create patron attributes
which have both "Display in OPAC" and "Editable in OPAC" checked.

- Create one which is tied to an authorized value, and one which isn't.
- Log in to the OPAC and click the "Personal details" tab.
- In the entry form, find the patron attribute fields under the
  Additional information" heading..
- Select a value in the dropdown, and enter text in the textarea.
- Confirm that clicking the corresponding "Clear" link for each works as
  expected.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2023-11-07 21:25:30 UTC
Created attachment 158623 [details] [review]
Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form

This patch makes a minor correction to the JavaScript controlling the
behavior of the "clear" link which appears on the patron entry form next
to patron attribute <select>s or <textarea>s which are editable in the
OPAC.

To test, apply the patch and create patron attributes
which have both "Display in OPAC" and "Editable in OPAC" checked.

- Create one which is tied to an authorized value, and one which isn't.
- Log in to the OPAC and click the "Personal details" tab.
- In the entry form, find the patron attribute fields under the
  Additional information" heading..
- Select a value in the dropdown, and enter text in the textarea.
- Confirm that clicking the corresponding "Clear" link for each works as
  expected.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-11-08 14:43:12 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-10 20:44:47 UTC
Pushed to 23.05.x for 23.05.06
Comment 6 Pedro Amorim 2023-11-14 14:50:39 UTC
Nice work everyone!

Pushed to 22.11.x for next release