Bug 35298 - Flatpickr makes focus handler in dateaccessioned plugin useless
Summary: Flatpickr makes focus handler in dateaccessioned plugin useless
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-09 08:04 UTC by Marcel de Rooy
Modified: 2023-11-16 09:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.06,22.11.12


Attachments
Bug 35298: Remove focus handler from dateaccessioned plugin. (1.03 KB, patch)
2023-11-09 08:10 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 35298: Remove focus handler from dateaccessioned plugin. (1.04 KB, patch)
2023-11-09 11:32 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35298: Remove focus handler from dateaccessioned plugin. (1.10 KB, patch)
2023-11-10 17:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-11-09 08:04:01 UTC
See also bug 31665.
Remove focus handler from dateaccessioned plugin.
The onOpen from flatpickr has control now.
Comment 1 Marcel de Rooy 2023-11-09 08:10:13 UTC
Created attachment 158702 [details] [review]
Bug 35298: Remove focus handler from dateaccessioned plugin.

Test plan:
Verify that setting focus to date acquired field in items editor
fills date of today when field is empty but does not replace existing
date.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-11-09 08:10:53 UTC
Super trivial: self SO
Comment 3 Owen Leonard 2023-11-09 11:32:09 UTC
Created attachment 158711 [details] [review]
Bug 35298: Remove focus handler from dateaccessioned plugin.

Test plan:
Verify that setting focus to date acquired field in items editor
fills date of today when field is empty but does not replace existing
date.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2023-11-09 21:02:59 UTC
I tried to test, but setting the focus in the field already pre-fills the date for me without applying this patch.

I tried clicking in the field and "tabbing" to it.

Tested in Firefox.
Comment 5 Marcel de Rooy 2023-11-10 06:59:43 UTC
Back to Signed off. This is just confusion about the expected results.
Comment 6 Marcel de Rooy 2023-11-10 07:00:21 UTC
(In reply to Katrin Fischer from comment #4)
> I tried to test, but setting the focus in the field already pre-fills the
> date for me without applying this patch.

Yes, but that is just Flatpickr. The removed focus handler simply does nothing.
Comment 7 Katrin Fischer 2023-11-10 17:40:49 UTC
Created attachment 158811 [details] [review]
Bug 35298: Remove focus handler from dateaccessioned plugin.

Test plan:
Verify that setting focus to date acquired field in items editor
fills date of today when field is empty but does not replace existing
date.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-11-14 13:33:09 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-11-14 18:53:00 UTC
Pushed to 23.05.x for 23.05.06
Comment 10 Matt Blenkinsop 2023-11-16 09:37:36 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x