Bug 35304 - Add new Sortable library to didyoumean configuration
Summary: Add new Sortable library to didyoumean configuration
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Emily Lamancusa
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 35194
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-09 16:13 UTC by Emily Lamancusa
Modified: 2023-11-11 07:39 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 35304: Add new Sortable library to didyoumean configuration (1.46 KB, patch)
2023-11-09 16:27 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 35304: Add new Sortable library to didyoumean configuration (1.52 KB, patch)
2023-11-09 16:58 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35304: Add new Sortable library to didyoumean configuration (1.57 KB, patch)
2023-11-09 20:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa 2023-11-09 16:13:05 UTC
Drag-and-drop isn't working on Administration > Did You Mean configuration. On a spot check of the code, it doesn't look like the new Sortable library introduced in bug 34114 was incorporated into didyoumean.tt
Comment 1 Emily Lamancusa 2023-11-09 16:27:17 UTC
Created attachment 158750 [details] [review]
Bug 35304: Add new Sortable library to didyoumean configuration

To test:
1. Go to Administration > Did You Mean
2. Attempt to drag and drop plugin options.
--> Confirm that they are not draggable
3. Apply patch and clear browser cache
4. Reload the page
--> Confirm that drag-and-drop now works
Comment 2 Lucas Gass 2023-11-09 16:58:43 UTC
Created attachment 158752 [details] [review]
Bug 35304: Add new Sortable library to didyoumean configuration

To test:
1. Go to Administration > Did You Mean
2. Attempt to drag and drop plugin options.
--> Confirm that they are not draggable
3. Apply patch and clear browser cache
4. Reload the page
--> Confirm that drag-and-drop now works

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2023-11-09 20:28:54 UTC
Created attachment 158766 [details] [review]
Bug 35304: Add new Sortable library to didyoumean configuration

To test:
1. Go to Administration > Did You Mean
2. Attempt to drag and drop plugin options.
--> Confirm that they are not draggable
3. Apply patch and clear browser cache
4. Reload the page
--> Confirm that drag-and-drop now works

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-11-10 14:02:51 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-11-11 07:39:04 UTC
Depends on Bug 35194 not in 23.05.x