Bug 35323 - Terminology: Add additional elements to the "More Searches" bar...
Summary: Terminology: Add additional elements to the "More Searches" bar...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-13 16:17 UTC by Katrin Fischer
Modified: 2024-02-09 20:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:


Attachments
"More searches" menu item on the OPAC detail page (129.10 KB, image/png)
2023-11-13 18:13 UTC, Owen Leonard
Details
Bug 35323: Fix hint for OpacMoreSearches HTML customization (1.55 KB, patch)
2024-01-06 19:52 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35323: Fix hint for OpacMoreSearches HTML customization (1.60 KB, patch)
2024-01-07 14:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 35323: Fix hint for OpacMoreSearches HTML customization (1.66 KB, patch)
2024-01-17 19:38 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-13 16:17:26 UTC
Found in translation:
Add additional elements to the "More Searches" bar on the OPAC, with this content (leave blank to disable). 

I don't think the element is labelled "More searches" anywhere in Koha - maybe we should call it "Navigation links below the simple search" or similar? 

Also: capitalization.
Comment 1 Owen Leonard 2023-11-13 18:13:28 UTC
Created attachment 158896 [details]
"More searches" menu item on the OPAC detail page
Comment 2 Katrin Fischer 2023-11-13 20:13:17 UTC
Yes, you would think that, but it's actually not the spot.

OpacMoreSearches appears in the OPAC navigation - I just tested.

You mean  OPACSearchForTitleIn, this has not been migrated to HTML customizations yet.
Comment 3 Katrin Fischer 2024-01-06 19:52:33 UTC
Created attachment 160602 [details] [review]
Bug 35323: Fix hint for OpacMoreSearches HTML customization

There was some confusion on where this content appears.
This patch fixes the description shown as hint in the HTML
customizations tool when when the OpacMoreSearches entry is
selected.

To test:
* Before appyling the patch
* Add a new HTML customization for OpacMoreSearches
* Verif hint showing below the pull down
* Set a title and a publication date in the past
* Enter a short text, like "Koha" as content
* Save
* Go to the OPAC, verify text shows in the navigation
* Apply patch
* Verify hint is now correct
Comment 4 David Nind 2024-01-07 14:51:45 UTC
Created attachment 160610 [details] [review]
Bug 35323: Fix hint for OpacMoreSearches HTML customization

There was some confusion on where this content appears.
This patch fixes the description shown as hint in the HTML
customizations tool when when the OpacMoreSearches entry is
selected.

To test:
* Before appyling the patch
* Add a new HTML customization for OpacMoreSearches
* Verif hint showing below the pull down
* Set a title and a publication date in the past
* Enter a short text, like "Koha" as content
* Save
* Go to the OPAC, verify text shows in the navigation
* Apply patch
* Verify hint is now correct

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Victor Grousset/tuxayo 2024-01-17 19:38:57 UTC
Created attachment 161118 [details] [review]
Bug 35323: Fix hint for OpacMoreSearches HTML customization

There was some confusion on where this content appears.
This patch fixes the description shown as hint in the HTML
customizations tool when when the OpacMoreSearches entry is
selected.

To test:
* Before appyling the patch
* Add a new HTML customization for OpacMoreSearches
* Verif hint showing below the pull down
* Set a title and a publication date in the past
* Enter a short text, like "Koha" as content
* Save
* Go to the OPAC, verify text shows in the navigation
* Apply patch
* Verify hint is now correct

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2024-01-17 19:39:18 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Katrin Fischer 2024-01-26 14:17:37 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2024-01-31 13:56:46 UTC
Pushed to 23.11.x for 23.11.03
Comment 9 Lucas Gass 2024-02-09 20:33:36 UTC
No html-customization-help.inc in 23.05.x, no backport.