Bug 35347 - 'More information' should always display in cookie consent bar
Summary: 'More information' should always display in cookie consent bar
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on: 34793
Blocks: 34792 35346
  Show dependency treegraph
 
Reported: 2023-11-16 11:19 UTC by Martin Renvoize
Modified: 2024-03-26 10:21 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 35347: Display 'More information' button regardless of JSConsents (3.89 KB, patch)
2023-11-16 13:17 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 35347: Display 'More information' button regardless of JSConsents (3.94 KB, patch)
2023-11-20 09:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too (1.66 KB, patch)
2024-02-11 07:06 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 35347: Display 'More information' button regardless of JSConsents (4.00 KB, patch)
2024-02-12 15:51 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too (1.66 KB, patch)
2024-02-12 15:51 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2023-11-16 11:19:05 UTC
Even if we only have essential cookies use on the system, if the CookieConsent option is set to required the footer conent bar should display the 'More information' button so a user can make an informed decision whether to continue using the site or not.
Comment 1 Martin Renvoize 2023-11-16 13:17:15 UTC
Created attachment 159045 [details] [review]
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.
Comment 2 David Nind 2023-11-20 09:51:20 UTC
Created attachment 159136 [details] [review]
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2024-02-11 07:06:30 UTC
Created attachment 162013 [details] [review]
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
Comment 4 Victor Grousset/tuxayo 2024-02-11 18:01:35 UTC
All good for me. Waiting for bug 34793.
Comment 5 Victor Grousset/tuxayo 2024-02-12 15:51:48 UTC
Created attachment 162057 [details] [review]
Bug 35347: Display 'More information' button regardless of JSConsents

This patch moves the "More informatin" button outside of the JSConsents
block so that you are able to access the information modal regardless of
whether you have tracking cookies added to your configuration or not.

Test plan
1) Enable CookieConsent
2) Note that the 'More information' button now appears in the footer on
   both staff and opac until you have accepted cookies.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2024-02-12 15:51:50 UTC
Created attachment 162058 [details] [review]
Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
Comment 7 Victor Grousset/tuxayo 2024-02-12 15:52:21 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 8 Katrin Fischer 2024-03-26 10:09:42 UTC
Note:
<button type="button" class="btn btn-info" id="consentMoreInfo" aria-label="Click to view more information about your cookie consents">

The "click to view" is not needed here as it's marked as a button. Accessibility guidelines recommend to not use click and similar on links and such. Unrelated to the patch (pre-existing), but maybe someone wants to pick it up as an academy bug.
Comment 9 Katrin Fischer 2024-03-26 10:21:56 UTC
Pushed for 24.05!

Well done everyone, thank you!