Even if we only have essential cookies use on the system, if the CookieConsent option is set to required the footer conent bar should display the 'More information' button so a user can make an informed decision whether to continue using the site or not.
Created attachment 159045 [details] [review] Bug 35347: Display 'More information' button regardless of JSConsents This patch moves the "More informatin" button outside of the JSConsents block so that you are able to access the information modal regardless of whether you have tracking cookies added to your configuration or not. Test plan 1) Enable CookieConsent 2) Note that the 'More information' button now appears in the footer on both staff and opac until you have accepted cookies.
Created attachment 159136 [details] [review] Bug 35347: Display 'More information' button regardless of JSConsents This patch moves the "More informatin" button outside of the JSConsents block so that you are able to access the information modal regardless of whether you have tracking cookies added to your configuration or not. Test plan 1) Enable CookieConsent 2) Note that the 'More information' button now appears in the footer on both staff and opac until you have accepted cookies. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 162013 [details] [review] Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
All good for me. Waiting for bug 34793.
Created attachment 162057 [details] [review] Bug 35347: Display 'More information' button regardless of JSConsents This patch moves the "More informatin" button outside of the JSConsents block so that you are able to access the information modal regardless of whether you have tracking cookies added to your configuration or not. Test plan 1) Enable CookieConsent 2) Note that the 'More information' button now appears in the footer on both staff and opac until you have accepted cookies. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 162058 [details] [review] Bug 35347: (QA follow-up): swap "essential" and "all" for OPAC too
Works, makes sense, QA script happy, code looks good, passing QA :)
Note: <button type="button" class="btn btn-info" id="consentMoreInfo" aria-label="Click to view more information about your cookie consents"> The "click to view" is not needed here as it's marked as a button. Accessibility guidelines recommend to not use click and similar on links and such. Unrelated to the patch (pre-existing), but maybe someone wants to pick it up as an academy bug.
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 34793 not in 23.11.x