Bug 35362 - Update patron module pop-up windows with consistent footer markup
Summary: Update patron module pop-up windows with consistent footer markup
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
: 36706 (view as bug list)
Depends on: 34343
Blocks: 36706
  Show dependency treegraph
 
Reported: 2023-11-17 16:28 UTC by Owen Leonard
Modified: 2024-07-25 11:15 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:


Attachments
Bug 35362: Update patron module pop-up windows with consistent footer markup (5.30 KB, patch)
2023-11-17 16:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35362: Update patron module pop-up windows with consistent footer markup (5.36 KB, patch)
2023-11-17 21:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35362: Update patron module pop-up windows with consistent footer markup (5.41 KB, patch)
2024-02-23 16:22 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 35362: (follow-up) Fix preview close on guarantor add (1.46 KB, patch)
2024-04-26 07:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 35362: (follow-up) Fix guaruntor preview modal close in test (1.96 KB, patch)
2024-04-26 07:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 35362: Adjust other "Close window" clicks (1.50 KB, patch)
2024-05-14 09:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-11-17 16:28:32 UTC
I would like to update two pop-up windows in the patron module to be consistent with Bug 34343 and its children:

- Brief patron view
- Update child to adult category selection
Comment 1 Owen Leonard 2023-11-17 16:46:46 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass (lukeg) 2023-11-17 21:57:16 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2024-02-23 16:22:18 UTC
Created attachment 162390 [details] [review]
Bug 35362: Update patron module pop-up windows with consistent footer markup

This patch updates two patron-related templates in order to style
submission and close buttons in a fixed footer at the bottom of the
window, with markup consistent with other pop-up windows.

The patch also updates the "Update child" popup js so that it uses
the same window-opening function we use elsewhere. I also added form
validation to the category selection form to help prevent errors if
someone submits the form without making a selection.

To test, apply the patch and go to the Patrons module

- Click "New patron" and add a patron with the same first and last name
  of a patron already in the database.
- When you save the new patron record the page should reload with an
  error message: "Duplicate patron record?"
- Click "View existing record"
- A pop-up window should appear with patron information.
- Confirm that the window's footer looks correct.

- Locate a patron with an age-limited child category. In the sample data
  the "Juvenile" category works.
- View the patron detail page and click More -> Update child to adult
  patron.
- A pop-up window should appear with patron category selection options.
- Try submitting the form without making a selection. You should see a
  message about fields being required.
- Select a category and submit the form to confirm that the controls
  work correctly.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-04-19 16:32:10 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Martin Renvoize (ashimema) 2024-04-26 06:44:27 UTC
This one breaks the patron search selenium tests.. but more importantly the test highlights a breakage... you can no longer close the patron preview modal.

I have the fix, will post shortly.
Comment 6 Martin Renvoize (ashimema) 2024-04-26 07:13:36 UTC
Created attachment 165609 [details] [review]
Bug 35362: (follow-up) Fix preview close on guarantor add

When adding a guarantor you are given a patron search modal. If you then
preview a search result, the preview modal could not be closed. It's a
simple update for 'close' to 'close_window' in the jQuery selector.
Comment 7 Martin Renvoize (ashimema) 2024-04-26 07:13:38 UTC
Created attachment 165610 [details] [review]
Bug 35362: (follow-up) Fix guaruntor preview modal close in test

This patch updates the selenium test to correct the selector used to
close the preview modal as it changed with this patchset.
Comment 8 Martin Renvoize (ashimema) 2024-04-26 09:03:04 UTC
There's another selenium failure further down the patron search test.. but I can't seem to resolve that one :(.

More eyes are needed, please.
Comment 9 Martin Renvoize (ashimema) 2024-04-30 06:58:46 UTC
*** Bug 36706 has been marked as a duplicate of this bug. ***
Comment 10 Katrin Fischer 2024-04-30 07:40:35 UTC
Forgot to put a note: the first 2 follow-ups are already pushed to main. 
Not sure about the missing Selenium fix?
Comment 11 Jonathan Druart 2024-05-14 09:52:03 UTC
Created attachment 166682 [details] [review]
Bug 35362: Adjust other "Close window" clicks

Previous patch "Bug 35362: (follow-up) Fix guaruntor preview modal close in test"
didn't adjust the other occurrences.
Comment 12 Jonathan Druart 2024-05-14 09:52:38 UTC
Tests still fail but we need this follow-up here. Working on it.
Comment 13 Jonathan Druart 2024-05-14 12:51:32 UTC
(In reply to Jonathan Druart from comment #12)
> Tests still fail but we need this follow-up here. Working on it.

2 follow-ups added on bug 35862.
Comment 14 Katrin Fischer 2024-05-14 12:53:49 UTC
Picked the follow-up "Adjust other..." for main.
Comment 15 Fridolin Somers 2024-05-23 13:58:27 UTC
Not backported to 23.11.x