I would like to update two pop-up windows in the patron module to be consistent with Bug 34343 and its children: - Brief patron view - Update child to adult category selection
Created attachment 159096 [details] [review] Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly.
Created attachment 159118 [details] [review] Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 162390 [details] [review] Bug 35362: Update patron module pop-up windows with consistent footer markup This patch updates two patron-related templates in order to style submission and close buttons in a fixed footer at the bottom of the window, with markup consistent with other pop-up windows. The patch also updates the "Update child" popup js so that it uses the same window-opening function we use elsewhere. I also added form validation to the category selection form to help prevent errors if someone submits the form without making a selection. To test, apply the patch and go to the Patrons module - Click "New patron" and add a patron with the same first and last name of a patron already in the database. - When you save the new patron record the page should reload with an error message: "Duplicate patron record?" - Click "View existing record" - A pop-up window should appear with patron information. - Confirm that the window's footer looks correct. - Locate a patron with an age-limited child category. In the sample data the "Juvenile" category works. - View the patron detail page and click More -> Update child to adult patron. - A pop-up window should appear with patron category selection options. - Try submitting the form without making a selection. You should see a message about fields being required. - Select a category and submit the form to confirm that the controls work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
This one breaks the patron search selenium tests.. but more importantly the test highlights a breakage... you can no longer close the patron preview modal. I have the fix, will post shortly.
Created attachment 165609 [details] [review] Bug 35362: (follow-up) Fix preview close on guarantor add When adding a guarantor you are given a patron search modal. If you then preview a search result, the preview modal could not be closed. It's a simple update for 'close' to 'close_window' in the jQuery selector.
Created attachment 165610 [details] [review] Bug 35362: (follow-up) Fix guaruntor preview modal close in test This patch updates the selenium test to correct the selector used to close the preview modal as it changed with this patchset.
There's another selenium failure further down the patron search test.. but I can't seem to resolve that one :(. More eyes are needed, please.
*** Bug 36706 has been marked as a duplicate of this bug. ***
Forgot to put a note: the first 2 follow-ups are already pushed to main. Not sure about the missing Selenium fix?
Created attachment 166682 [details] [review] Bug 35362: Adjust other "Close window" clicks Previous patch "Bug 35362: (follow-up) Fix guaruntor preview modal close in test" didn't adjust the other occurrences.
Tests still fail but we need this follow-up here. Working on it.
(In reply to Jonathan Druart from comment #12) > Tests still fail but we need this follow-up here. Working on it. 2 follow-ups added on bug 35862.
Picked the follow-up "Adjust other..." for main.
Not backported to 23.11.x