Bug 35406 - Typo in holds queue viewer template
Summary: Typo in holds queue viewer template
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on: 34160
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-27 15:08 UTC by Tomás Cohen Arazi
Modified: 2024-02-01 16:20 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35406: Fix typo in holds queue viewer template (2.20 KB, patch)
2023-11-27 15:09 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35406: (follow-up) More HTML fixes (6.18 KB, patch)
2023-11-29 13:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35406: Fix typo in holds queue viewer template (2.25 KB, patch)
2023-11-29 22:32 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35406: (follow-up) More HTML fixes (6.23 KB, patch)
2023-11-29 22:32 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35406: Fix typo in holds queue viewer template (2.32 KB, patch)
2024-01-24 14:29 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 35406: (follow-up) More HTML fixes (6.30 KB, patch)
2024-01-24 14:29 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2023-11-27 15:08:05 UTC
Found it while translating <<a...>
Comment 1 Tomás Cohen Arazi 2023-11-27 15:09:12 UTC
Created attachment 159273 [details] [review]
Bug 35406: Fix typo in holds queue viewer template

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Phil Ringnalda 2023-11-27 18:57:15 UTC
Shouldn't it be changing to </a></strong>, not to </a>/strong>?
Comment 3 Owen Leonard 2023-11-29 13:53:03 UTC
Created attachment 159337 [details] [review]
Bug 35406: (follow-up) More HTML fixes

This patch fixes even more markup errors and HTML validation issues.
Comment 4 Phil Ringnalda 2023-11-29 22:32:09 UTC
Created attachment 159377 [details] [review]
Bug 35406: Fix typo in holds queue viewer template

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 5 Phil Ringnalda 2023-11-29 22:32:11 UTC
Created attachment 159378 [details] [review]
Bug 35406: (follow-up) More HTML fixes

This patch fixes even more markup errors and HTML validation issues.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 6 Emily Lamancusa 2024-01-24 14:29:43 UTC
Created attachment 161336 [details] [review]
Bug 35406: Fix typo in holds queue viewer template

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa 2024-01-24 14:29:45 UTC
Created attachment 161337 [details] [review]
Bug 35406: (follow-up) More HTML fixes

This patch fixes even more markup errors and HTML validation issues.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 8 Emily Lamancusa 2024-01-24 14:30:39 UTC
Looks good, QA script happy. Passing QA
Comment 9 Katrin Fischer 2024-01-30 16:50:13 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 10 Fridolin Somers 2024-02-01 16:20:30 UTC
Pushed to 23.11.x for 23.11.03