Bug 35415 - Rephrase: Some patrons have requested a privacy ...
Summary: Rephrase: Some patrons have requested a privacy ...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 13:00 UTC by Katrin Fischer
Modified: 2023-12-14 20:57 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01


Attachments
Bug 35415: Rephrase: Some patrons have requested a privacy ... (2.54 KB, patch)
2023-12-01 12:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35415: Rephrase: Some patrons have requested a privacy ... (2.60 KB, patch)
2023-12-01 15:22 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35415: Rephrase: Some patrons have requested a privacy ... (2.66 KB, patch)
2023-12-07 07:03 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-28 13:00:18 UTC
The first sentence here doen't read quite right:

koha-tmpl/intranet-tmpl/prog/en/modules/about.tt:447 

Some patrons have requested a privacy on returning item, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail.

Also: 
Returning should be checking in
Comment 1 Owen Leonard 2023-11-28 19:24:16 UTC
How about:

Some patrons have requested privacy after their items are checked in, but the AnonymousPatron preference is not set correctly. Set it to a valid borrower number or checkins for these patrons will fail.
Comment 2 Katrin Fischer 2023-11-30 22:14:31 UTC
Sounds better to me :)
Comment 3 Owen Leonard 2023-12-01 12:29:36 UTC
Created attachment 159447 [details] [review]
Bug 35415: Rephrase: Some patrons have requested a privacy ...

This patch revises the wording of the warning which is displayed on the
'About' page when the 'OPACPrivacy' system preference is enabled but the
'AnonymousPatron' preference is empty. The new phrasing is hopefully
more clear.

To test, apply the patch and go to Administration -> System preferences.

- Search for 'AnonymousPatron' and enter a borrowernumber if necessary.
- Log in to the OPAC and click the 'Privacy' tab in the left-hand
  sidebar of the user summary page.
- Set your privacy rule to 'Never'.

- Return to Admnistration -> Sytem preferences in the staff interface.
- Search for 'OPACPrivacy' and set it to 'Allow'.
- Clear the borrowernumber from the 'AnonymousPatron' preference.
- Go to the 'About" page and open the 'System information' tab.
- You should see an error message at the bottom:

  "Some patrons have requested privacy after their items are checked in,
   but the AnonymousPatron preference is not set correctly. Set it to a
   valid borrower number or checkins for these patrons will fail."
Comment 4 ByWater Sandboxes 2023-12-01 15:22:18 UTC
Created attachment 159453 [details] [review]
Bug 35415: Rephrase: Some patrons have requested a privacy ...

This patch revises the wording of the warning which is displayed on the
'About' page when the 'OPACPrivacy' system preference is enabled but the
'AnonymousPatron' preference is empty. The new phrasing is hopefully
more clear.

To test, apply the patch and go to Administration -> System preferences.

- Search for 'AnonymousPatron' and enter a borrowernumber if necessary.
- Log in to the OPAC and click the 'Privacy' tab in the left-hand
  sidebar of the user summary page.
- Set your privacy rule to 'Never'.

- Return to Admnistration -> Sytem preferences in the staff interface.
- Search for 'OPACPrivacy' and set it to 'Allow'.
- Clear the borrowernumber from the 'AnonymousPatron' preference.
- Go to the 'About" page and open the 'System information' tab.
- You should see an error message at the bottom:

  "Some patrons have requested privacy after their items are checked in,
   but the AnonymousPatron preference is not set correctly. Set it to a
   valid borrower number or checkins for these patrons will fail."

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 5 Victor Grousset/tuxayo 2023-12-07 07:03:12 UTC
Created attachment 159631 [details] [review]
Bug 35415: Rephrase: Some patrons have requested a privacy ...

This patch revises the wording of the warning which is displayed on the
'About' page when the 'OPACPrivacy' system preference is enabled but the
'AnonymousPatron' preference is empty. The new phrasing is hopefully
more clear.

To test, apply the patch and go to Administration -> System preferences.

- Search for 'AnonymousPatron' and enter a borrowernumber if necessary.
- Log in to the OPAC and click the 'Privacy' tab in the left-hand
  sidebar of the user summary page.
- Set your privacy rule to 'Never'.

- Return to Admnistration -> Sytem preferences in the staff interface.
- Search for 'OPACPrivacy' and set it to 'Allow'.
- Clear the borrowernumber from the 'AnonymousPatron' preference.
- Go to the 'About" page and open the 'System information' tab.
- You should see an error message at the bottom:

  "Some patrons have requested privacy after their items are checked in,
   but the AnonymousPatron preference is not set correctly. Set it to a
   valid borrower number or checkins for these patrons will fail."

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2023-12-07 07:03:31 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Katrin Fischer 2023-12-07 11:05:45 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2023-12-07 21:22:12 UTC
Pushed to 23.11.x for 23.11.01
Comment 9 Lucas Gass 2023-12-14 20:57:10 UTC
Not needed in 23.05.x, no backport.