Bug 35419 - Update page title for bookings
Summary: Update page title for bookings
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 29002
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-28 14:12 UTC by Katrin Fischer
Modified: 2024-02-07 23:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:


Attachments
Bug 35419: Update page title for bookings (1.66 KB, patch)
2023-11-28 17:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35419: Update page title for bookings (1.73 KB, patch)
2023-12-01 15:35 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35419: Update page title for bookings (1.73 KB, patch)
2023-12-18 12:54 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-28 14:12:11 UTC

    
Comment 1 Katrin Fischer 2023-11-28 14:13:11 UTC
I can see some suspicious strings in translations that indicate, that we should also update those to the new structure:

Bookings for %s › Bookings › Circulation › Koha
Comment 2 Owen Leonard 2023-11-28 17:54:02 UTC
Created attachment 159310 [details] [review]
Bug 35419: Update page title for bookings

This patch updates the structure of the Bookings list page so that the
title can be better translated.

To test, apply the patch and locate a bibliographic record in the
staff interface catalog.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
    "Yes."
- Click the "Bookings" menu item in the left-hand sidebar.
- Check that the page title looks correct and consistent with
  breadcrumbs.
Comment 3 ByWater Sandboxes 2023-12-01 15:35:29 UTC
Created attachment 159455 [details] [review]
Bug 35419: Update page title for bookings

This patch updates the structure of the Bookings list page so that the
title can be better translated.

To test, apply the patch and locate a bibliographic record in the
staff interface catalog.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
    "Yes."
- Click the "Bookings" menu item in the left-hand sidebar.
- Check that the page title looks correct and consistent with
  breadcrumbs.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-12-18 12:54:26 UTC
Created attachment 159962 [details] [review]
Bug 35419: Update page title for bookings

This patch updates the structure of the Bookings list page so that the
title can be better translated.

To test, apply the patch and locate a bibliographic record in the
staff interface catalog.

- View the detail page.
- If you don't see a "Place booking" button in the toolbar,
  click "Items" in the sidebar menu.
  - Locate the "Priority" heading, and change the "Bookable" setting to
    "Yes."
- Click the "Bookings" menu item in the left-hand sidebar.
- Check that the page title looks correct and consistent with
  breadcrumbs.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 5 Katrin Fischer 2023-12-18 14:33:29 UTC
Tomas: please add your sign-off line :)
Comment 6 Katrin Fischer 2024-01-16 15:36:07 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-31 12:23:05 UTC
Pushed to 23.11.x for 23.11.03