Bug 35425 - Sortable prevents mouse selection of text inside child input/textarea elements
Summary: Sortable prevents mouse selection of text inside child input/textarea elements
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Slava Shishkin
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 35383
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-28 18:42 UTC by Slava Shishkin
Modified: 2023-12-14 21:18 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01
Circulation function:


Attachments
Bug 35425: Optimize UX when dragging a Tag or Subfield (5.24 KB, patch)
2023-11-28 19:18 UTC, Slava Shishkin
Details | Diff | Splinter Review
Bug 35425: Optimize UX when dragging a Tag or Subfield (5.29 KB, patch)
2023-11-29 22:55 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 35425: Optimize UX when dragging a Tag or Subfield (5.39 KB, patch)
2023-12-01 07:47 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Slava Shishkin 2023-11-28 18:42:39 UTC
To reproduce:
1. Open any biblio and edit that record. 
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly.
Comment 1 Slava Shishkin 2023-11-28 19:18:16 UTC
Created attachment 159313 [details] [review]
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record. 
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea 
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click 
   on the "::" icon in front of the dragged item. And text selection 
   works correctly.
Comment 2 Phil Ringnalda 2023-11-29 22:55:38 UTC
Created attachment 159379 [details] [review]
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record.
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click
   on the "::" icon in front of the dragged item. And text selection
   works correctly.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Marcel de Rooy 2023-12-01 07:47:17 UTC
Created attachment 159426 [details] [review]
Bug 35425: Optimize UX when dragging a Tag or Subfield

To reproduce:
1. Open any biblio and edit that record.
   (select "Edit record" from the "Edit" drop-down menu).
2. Check that selecting the text in any draggable block input/textarea
   fields with a mouse is not possible - it starts dragging instantly.
3. Apply the patch
4. Make sure that draging is activated only when you click
   on the "::" icon in front of the dragged item. And text selection
   works correctly.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2023-12-11 18:12:14 UTC
More a bug than an enh!
Comment 5 Katrin Fischer 2023-12-11 18:19:06 UTC
This fixes the buggy behavior, but in testing this I feel like we might think about improving UX a bit more (on a separate bug). I believe that our drag & drop is not very accessible and a little hard to handle when you are on a slow system.
Comment 6 Katrin Fischer 2023-12-11 18:47:08 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2023-12-12 07:39:31 UTC
Pushed to 23.11.x for 23.11.01
Comment 8 Lucas Gass (lukeg) 2023-12-14 21:18:28 UTC
Missing dependencies for 23.05.x, no backport.