The bookings modal form, triggered on the staff interface page when you click the "Place bookings" button, has an awkward layout because the fieldset with "rows" class doesn't work well there. Changing the class to "brief" makes it work better.
Created attachment 159312 [details] [review] Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved.
Created attachment 159454 [details] [review] Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Created attachment 159963 [details] [review] Bug 35426: Improve layout of bookings modal form This patch changes the class on the bookings modal form's fieldset in order to make the form work better in the small space offered by the modal. Also changed: The hint for the patron search field has been moved below the field for consistency. To test, apply the patch and search for a title in the staff interface. - View the detail page. - If you don't see a "Place booking" button in the toolbar, click "Items" in the sidebar menu. - Locate the "Priority" heading, and change the "Bookable" setting to "Yes." - Click the "PLace booking" button in the toolbar. - The bookings modal form should appear, and the form layout should be improved. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.05! Well done everyone, thank you!
I'm not sure I agree this looks better... now it's pushed the modal looks more odd to me than it did before.
Created attachment 162974 [details] Old vs New
Can we do better here in general for modal based forms Owen?
In fact.. all the modals I've created that include a form use 'rows' rather than 'brief' and personally I think they're clearer looking.. see all the modals available on the accounts pages?
Small enhancement, I choose to backport Pushed to 23.11.x for 23.11.04
Ah reading comments I prefer not backport
I think we can backport this regardless of my negative comments.. I'd just love to see us get more consistent overall somehow in the future.
Pushed to 23.11.x for 23.11.04
Missing dependencies for 23.05.x, no backport.