Bug 35428 - gulp po tasks do not clean temporary files
Summary: gulp po tasks do not clean temporary files
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: translate.koha-community.org (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low major (vote)
Assignee: Jonathan Druart
QA Contact: Kyle M Hall
URL:
Keywords:
Depends on:
Blocks: 36730
  Show dependency treegraph
 
Reported: 2023-11-29 09:01 UTC by Jonathan Druart
Modified: 2024-04-30 10:16 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 35428: Remove temporary files for gulp po tasks (1.04 KB, patch)
2023-11-29 09:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35428: Remove temporary files for gulp po tasks (1.08 KB, patch)
2023-11-29 09:34 UTC, David Nind
Details | Diff | Splinter Review
Bug 35428: Remove temporary files for gulp po tasks (1.14 KB, patch)
2023-12-01 17:41 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-11-29 09:01:35 UTC
gulp po:update will generate 1 /tmp/koha-* directory per task.

We need to remove them when the script does not longer need them.
Comment 1 Jonathan Druart 2023-11-29 09:02:41 UTC
To give an idea, on the translator server, for one month:
% du -hc /tmp/koha-*
1.6G	total
Comment 2 Jonathan Druart 2023-11-29 09:04:36 UTC
Created attachment 159317 [details] [review]
Bug 35428: Remove temporary files for gulp po tasks

gulp po:update will generate 1 /tmp/koha-* directory per task.

We need to remove them when the script does not longer need them.

Test plan:
0. Do not apply this patch
1. ls -ltr /tmp
2. gulp po:update --lang es-ES
3. ls -ltr /tmp
=> Notice new koha-* directories
Repeat 2, 3
4. Apply this patch and try again
=> No new directories when the job is done
Comment 3 David Nind 2023-11-29 09:34:44 UTC
Created attachment 159318 [details] [review]
Bug 35428: Remove temporary files for gulp po tasks

gulp po:update will generate 1 /tmp/koha-* directory per task.

We need to remove them when the script does not longer need them.

Test plan:
0. Do not apply this patch
1. ls -ltr /tmp
2. gulp po:update --lang es-ES
3. ls -ltr /tmp
=> Notice new koha-* directories
Repeat 2, 3
4. Apply this patch and try again
=> No new directories when the job is done

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Kyle M Hall 2023-12-01 17:41:40 UTC
Created attachment 159470 [details] [review]
Bug 35428: Remove temporary files for gulp po tasks

gulp po:update will generate 1 /tmp/koha-* directory per task.

We need to remove them when the script does not longer need them.

Test plan:
0. Do not apply this patch
1. ls -ltr /tmp
2. gulp po:update --lang es-ES
3. ls -ltr /tmp
=> Notice new koha-* directories
Repeat 2, 3
4. Apply this patch and try again
=> No new directories when the job is done

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Katrin Fischer 2023-12-13 10:35:25 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 13:16:57 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-04 18:15:06 UTC
Backported to 23.05.x for upcoming 23.05.08