Bug 35436 - Copy is not translatable in OPAC search history
Summary: Copy is not translatable in OPAC search history
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-29 16:14 UTC by Adolfo Rodríguez Taboada
Modified: 2023-12-14 21:22 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01,23.05.07


Attachments
OPAC Search History Capture (32.16 KB, image/png)
2023-11-29 16:14 UTC, Adolfo Rodríguez Taboada
Details
Fix - Bug 35436 - Copy is not translatable in OPAC Search History (1.94 KB, patch)
2023-11-29 16:17 UTC, Adolfo Rodríguez Taboada
Details | Diff | Splinter Review
Fix - Bug 35436 - Copy is not translatable in OPAC Search History (1.97 KB, patch)
2023-11-30 10:07 UTC, Adolfo Rodríguez Taboada
Details | Diff | Splinter Review
Fix - Bug 35436 - Copy is not translatable in OPAC Search History (2.82 KB, patch)
2023-11-30 10:13 UTC, Adolfo Rodríguez Taboada
Details | Diff | Splinter Review
Bug 35436: Copy is not translatable in OPAC Search History (2.87 KB, patch)
2023-12-01 17:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35436: Copy is not translatable in OPAC Search History (2.92 KB, patch)
2023-12-07 19:58 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Adolfo Rodríguez Taboada 2023-11-29 16:14:05 UTC
Created attachment 159349 [details]
OPAC Search History Capture

Copy in the table of OPAC Search History isn't translatable.
Comment 1 Adolfo Rodríguez Taboada 2023-11-29 16:17:20 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-11-29 18:20:49 UTC
With this patch the responsive behavior of the DataTable is buggy: The last column, which is supposed to be hidden at wider browser widths, is always visible. I notice also that the first column (checkboxes) is sortable. It should not be.

Please provide a test plan in your commit message!
Comment 3 Adolfo Rodríguez Taboada 2023-11-30 10:07:06 UTC Comment hidden (obsolete)
Comment 4 Adolfo Rodríguez Taboada 2023-11-30 10:13:05 UTC
Created attachment 159388 [details] [review]
Fix - Bug 35436 - Copy is not translatable in OPAC Search History

Test plan
1 Enter in OPAC Search History in a language other than English and check that Copy is not translated
2 Apply patch, restart services
3 Regenerate the templates for that language
4 Repeat step 1 and check that Copy appears now translated
Comment 5 Katrin Fischer 2023-11-30 22:36:34 UTC
Hi Adolfo, I don't see a connection between your patch and the translatability of the string, can you please explain?
Comment 6 Adolfo Rodríguez Taboada 2023-12-01 08:18:52 UTC
This is not intuitive. I noticed that in "your checkout history" Copy is translatable unlike in "your search history". I compared the way the table is created and saw that "your checkout history" uses KohaTable so I changed "your search history" to do the same and now Copy gets translated.
Comment 7 Owen Leonard 2023-12-01 17:26:37 UTC
Created attachment 159468 [details] [review]
Bug 35436: Copy is not translatable in OPAC Search History

Test plan
1 Enter in OPAC Search History in a language other than English and
  check that Copy is not translated
2 Apply patch, restart services
3 Regenerate the templates for that language
4 Repeat step 1 and check that Copy appears now translated

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 8 Victor Grousset/tuxayo 2023-12-07 19:58:53 UTC
Created attachment 159663 [details] [review]
Bug 35436: Copy is not translatable in OPAC Search History

Test plan
1 Enter in OPAC Search History in a language other than English and
  check that Copy is not translated
2 Apply patch, restart services
3 Regenerate the templates for that language
4 Repeat step 1 and check that Copy appears now translated

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 9 Victor Grousset/tuxayo 2023-12-07 19:59:05 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 10 Katrin Fischer 2023-12-11 18:47:11 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2023-12-12 07:45:38 UTC
Pushed to 23.11.x for 23.11.01
Comment 12 Lucas Gass 2023-12-14 21:22:58 UTC
Backported to 23.05.x for upcoming 23.05.07