Bug 35449 - Accessibility: No links on "here"
Summary: Accessibility: No links on "here"
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2023-11-30 10:10 UTC by Katrin Fischer
Modified: 2023-12-14 21:26 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01


Attachments
Bug 35449: Accessibility: No links on "here" (2.34 KB, patch)
2023-12-01 16:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35449: Accessibility: No links on "here" (2.39 KB, patch)
2023-12-01 19:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 35449: Accessibility: No links on "here" (2.45 KB, patch)
2023-12-07 20:16 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-30 10:10:23 UTC
We have some "here" links that slipped into system preference descriptions:

Example: UpdateItemLocationOnCheckin
<br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>.
Comment 1 Lucas Gass 2023-11-30 21:34:41 UTC
Is UpdateItemLocationOnCheckin correct? I don't see 'here' in that pref's description.

However:

kohadev-koha@kohadevbox:preferences(master)$ git grep '>here'
opac.pref:            - "<br><strong>NOTE:</strong> Library specific JS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>."
opac.pref:            - "<br><strong>NOTE:</strong> Library specific CSS can be defined from <a href='/cgi-bin/koha/admin/branches.pl'>here</a>."


The two places I am seeing is OPACUserJS and OPACUserCSS.
Comment 2 Katrin Fischer 2023-11-30 22:39:19 UTC
You are right, copy and paste from a wrong tab. Only the 2 to fix.
Comment 3 Owen Leonard 2023-12-01 16:53:01 UTC
Created attachment 159464 [details] [review]
Bug 35449: Accessibility: No links on "here"

This patch updates two system preferences, "OPACUserJS" and
"OPACUserCSS" so that the "here" links in the description instead read
"library administration".

To test, apply the patch and go to Administration -> System preferences.

- Search for "opacuser"
- The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences
  should include the phrase "...can be defined in library
  administration," with "library administration" leading to the correct
  page.
Comment 4 David Nind 2023-12-01 19:48:34 UTC
Created attachment 159481 [details] [review]
Bug 35449: Accessibility: No links on "here"

This patch updates two system preferences, "OPACUserJS" and
"OPACUserCSS" so that the "here" links in the description instead read
"library administration".

To test, apply the patch and go to Administration -> System preferences.

- Search for "opacuser"
- The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences
  should include the phrase "...can be defined in library
  administration," with "library administration" leading to the correct
  page.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Victor Grousset/tuxayo 2023-12-07 20:16:26 UTC
Created attachment 159665 [details] [review]
Bug 35449: Accessibility: No links on "here"

This patch updates two system preferences, "OPACUserJS" and
"OPACUserCSS" so that the "here" links in the description instead read
"library administration".

To test, apply the patch and go to Administration -> System preferences.

- Search for "opacuser"
- The descriptions of the "OPACUserJS" and "OPACUserCSS" preferences
  should include the phrase "...can be defined in library
  administration," with "library administration" leading to the correct
  page.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2023-12-07 20:16:52 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 7 Katrin Fischer 2023-12-11 18:47:14 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2023-12-12 07:49:51 UTC
Pushed to 23.11.x for 23.11.01
Comment 9 Lucas Gass 2023-12-14 21:26:34 UTC
Not needed in 23.05.x, no backport.