Bug 3545 - XSLT Stylesheet displays material type, format, audience icons based on leader/008 settings
Summary: XSLT Stylesheet displays material type, format, audience icons based on leade...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: rel_3_0
Hardware: PC All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Chris Cormack
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-23 07:11 UTC by Jane Wagner
Modified: 2012-10-25 22:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:11:58 UTC 


---- Reported by jwagner@ptfs.com 2009-08-23 19:11:33 ----

With XSLT on for OPAC results and details, the OPAC displays material type, format, audience icons based on leader/008 settings.  However, if the MARC record is incomplete or incorrect, the icon is either wrong or defaults to a generic setting which is not appropriate for the record.  Many sites migrating from older, limited systems will have MARC records with incorrect leader/008 fields.  Other sites may have persons creating new records who don't know the proper settings to enter.  In either case, the OPAC icons will not be correct.  Turning off XSLT altogether loses the other advantages of using XSLT, especially since future development is trending toward XSLT.

I've created a new syspref named DisplayOPACiconsXSLT and a patch (combined with fixes for http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3098 and http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3108) that makes the MARC21slim2OPACDetail.xsl and MARC21slim2OPACResults.xsl obey a setting to turn display of the icons off or on.



---- Additional Comments From jwagner@ptfs.com 2009-08-23 20:01:07 ----

Patch sent August 23, 2009.  



---- Additional Comments From gmcharlt@gmail.com 2009-09-16 01:41:43 ----

Patch pushed.  Please test and close.



---- Additional Comments From jwagner@ptfs.com 2009-09-16 15:47:02 ----

My original patch had a duplicated line which meant that record counts were getting doubled in the results list.  I've sent a new patch to fix that (removing one of the lines).



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:11 UTC  ---

This bug was previously known as _bug_ 3545 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3545

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was jwagner@ptfs.com.