Bug 35450 - Preservation system preferences should be authorised value pull downs
Summary: Preservation system preferences should be authorised value pull downs
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-30 10:32 UTC by Katrin Fischer
Modified: 2023-12-14 21:28 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01


Attachments
Bug 35450: Preservation system preferences should authval dropdowns (2.03 KB, patch)
2023-12-01 16:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35450: Preservation system preferences should authval dropdowns (2.09 KB, patch)
2023-12-01 19:49 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35450: Preservation system preferences should authval dropdowns (2.15 KB, patch)
2023-12-07 20:23 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-11-30 10:32:42 UTC
I noticed that the new preservation system preferences are missing the ending . at the end of the sentences.
Comment 1 Katrin Fischer 2023-11-30 10:33:49 UTC
... these also should be pull downs with the values (like we do for lost now) instead of input fields.
Comment 2 Owen Leonard 2023-12-01 16:41:15 UTC
Created attachment 159463 [details] [review]
Bug 35450: Preservation system preferences should authval dropdowns

This patch updates two preservation module system preferences so that
they offer dropdowns of "Not for loan" values instead of requiring entry
of a specific code.

The patch also adds a missing "." at the end of one preference
description.

To test, apply the patch and restart services.

- Go to Administration -> System preferences.
- Search for "preservation"
- Check that the "PreservationNotForLoanDefaultTrainIn" and
  "PreservationNotForLoanWaitingListIn" preferences have dropdowns
  offering "Not for loan" values.
- Confirm that your choices are correctly saved.
Comment 3 ByWater Sandboxes 2023-12-01 19:49:13 UTC
Created attachment 159482 [details] [review]
Bug 35450: Preservation system preferences should authval dropdowns

This patch updates two preservation module system preferences so that
they offer dropdowns of "Not for loan" values instead of requiring entry
of a specific code.

The patch also adds a missing "." at the end of one preference
description.

To test, apply the patch and restart services.

- Go to Administration -> System preferences.
- Search for "preservation"
- Check that the "PreservationNotForLoanDefaultTrainIn" and
  "PreservationNotForLoanWaitingListIn" preferences have dropdowns
  offering "Not for loan" values.
- Confirm that your choices are correctly saved.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 4 Victor Grousset/tuxayo 2023-12-07 20:23:22 UTC
Created attachment 159666 [details] [review]
Bug 35450: Preservation system preferences should authval dropdowns

This patch updates two preservation module system preferences so that
they offer dropdowns of "Not for loan" values instead of requiring entry
of a specific code.

The patch also adds a missing "." at the end of one preference
description.

To test, apply the patch and restart services.

- Go to Administration -> System preferences.
- Search for "preservation"
- Check that the "PreservationNotForLoanDefaultTrainIn" and
  "PreservationNotForLoanWaitingListIn" preferences have dropdowns
  offering "Not for loan" values.
- Confirm that your choices are correctly saved.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 5 Victor Grousset/tuxayo 2023-12-07 20:25:09 UTC
Good catch, it was possible to save any value in the syspref 💥 :o

Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 6 Katrin Fischer 2023-12-11 18:47:17 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2023-12-12 07:58:00 UTC
Pushed to 23.11.x for 23.11.01
Comment 8 Lucas Gass 2023-12-14 21:28:19 UTC
Not needed in 23.05.x, no backport.