Bug 35453 - Wrong 'Laserdisc)' string on 007 builder (MARC21)
Summary: Wrong 'Laserdisc)' string on 007 builder (MARC21)
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-30 12:42 UTC by Tomás Cohen Arazi
Modified: 2023-12-14 20:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.01,23.05.07


Attachments
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21) (1.56 KB, patch)
2023-11-30 12:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21) (1.60 KB, patch)
2023-11-30 18:30 UTC, David Nind
Details | Diff | Splinter Review
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21) (1.66 KB, patch)
2023-12-07 07:10 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2023-11-30 12:42:55 UTC
Cosmetic issue.

Steps to reproduce:
- On cataloguing, open the 007 builder.
- Choose material type 'Video recording'
- On 04 choose g - Laserdisc
- Click save
=> SUCCESS: 'g' correctly shows on the 007
- Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
Comment 1 Tomás Cohen Arazi 2023-11-30 12:49:22 UTC
Created attachment 159396 [details] [review]
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Steps to reproduce:
1. On cataloguing, open the 007 builder.
2. Choose material type 'Video recording'
3. On 04 choose g - Laserdisc
4. Click save
=> SUCCESS: 'g' correctly shows on the 007
5. Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
6. Apply this patch
7. Repeat 4 and 5
=> SUCCESS: no trailing ')'
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 David Nind 2023-11-30 18:30:17 UTC
Created attachment 159417 [details] [review]
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Steps to reproduce:
1. On cataloguing, open the 007 builder.
2. Choose material type 'Video recording'
3. On 04 choose g - Laserdisc
4. Click save
=> SUCCESS: 'g' correctly shows on the 007
5. Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
6. Apply this patch
7. Repeat 4 and 5
=> SUCCESS: no trailing ')'
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Victor Grousset/tuxayo 2023-12-07 07:10:14 UTC
Created attachment 159632 [details] [review]
Bug 35453: Fix wrong 'Laserdisc)' string on 007 builder (MARC21)

Steps to reproduce:
1. On cataloguing, open the 007 builder.
2. Choose material type 'Video recording'
3. On 04 choose g - Laserdisc
4. Click save
=> SUCCESS: 'g' correctly shows on the 007
5. Edit the 007 again
=> FAIL: on 04, 'g - Laserdisc)' is displayed
6. Apply this patch
7. Repeat 4 and 5
=> SUCCESS: no trailing ')'
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-07 07:10:56 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-07 11:05:51 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2023-12-07 21:23:04 UTC
Pushed to 23.11.x for 23.11.01
Comment 7 Lucas Gass 2023-12-14 20:58:37 UTC
Backported to 23.05.x for upcoming 23.05.07