When booking an item there is an untranslatable string in the modal: "Search for a patron" The calendar was also behaving a little oddly requiring a double click to take the date (just leaving the note here to see if someone else sees that)
Created attachment 159704 [details] [review] Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected
Inconsistent use of _() and __() in .js
Also I think that the following line content: _("Item") + " " + item.external_id, should be replaced with content: _("Item %s").format(item.external_id),
Created attachment 160284 [details] [review] Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected
Created attachment 160285 [details] [review] Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report.
Created attachment 160812 [details] [review] Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 160813 [details] [review] Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 160848 [details] [review] Bug 35475: Makes strings in booking JS file translatable This makes several strings in the booking specific JS file translatable. To test: * Make an item bookable: * Find a record with items in your catalog or create one * From the details page, switch to the items tab * Mark items as bookable * Add a booking, verify the modal works as expected * Check the bookings tab * Verify the column headings of the bookings table show correctly * Verify the "Biblio level" and "Item" in the calendar show Note: Months don't translate, this will be a separate bug * Cancel a booking, edit a booking... make sure everything works as expected * If you can: Install a translation and verify strings show up in po files as expected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 160849 [details] [review] Bug 35475: Improve concatenated string and fix error in JS file Fixes 2 problems noted in comment#2 and comment#3 on the bug report. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Yup, I agree, all looking good here.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Missing 23.05.x dependencies, no backport.