Might be me doing something wrong: I tried to add 3999900000611 to my created train in the preservation module, but I only get the "barcode not found, must be in waiting list". My waiting list is empty, adding the item there also fails.
Items can be added to a train if there are in the waiting list. > My waiting list is empty, adding the item there also fails. Which error do you get?
No error on the waiting list or only a very quick flicker and nothing in the console. I believe I might have been missing one digit in my barcode, but then the error is missing.
It says "No items added".
Created attachment 159580 [details] [review] Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well
Thank you!
Created attachment 159611 [details] [review] Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Created attachment 159927 [details] [review] Bug 35477: (QA follow-up): tidy up code
When having on valid barcode and one invalid: > 1 new items added. 1 items not found. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript Guideline JS5 does not explicitly asks for handling plural and singular forms but it's included example handles them. Should we consider it asks for handling plural and singular forms? --- testing notes: run `yarn build` before restarting the services.
What is the status of this?
Do we consider that the JS5 guideline requires handling plural and singular forms?
Yes, it should. But this is a discussion for somewhere else.
(In reply to Jonathan Druart from comment #11) > But this is a discussion for somewhere else. Ok, so it doesn't currently mandate it. So not failing QA for this. That was the thing that blocked me.
Created attachment 160387 [details] [review] Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 160388 [details] [review] Bug 35477: (QA follow-up): tidy up code Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Created attachment 160533 [details] [review] Bug 35477: Show a warning when non-existent items are added to the waiting list Only messages "X new items added" or "No items added" were displayed. With this patch we will display: A warning with "No items added" A warning with "X new items added. Y items not found." when some items have not been added A messages "X new items added" when everything went well Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Tidying inline.
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.02
Missing 23.05.x dependencies, no backport.