Bug 35483 - Restore item level to record level hold switch in hold table
Summary: Restore item level to record level hold switch in hold table
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lari Taskula
QA Contact: Tomás Cohen Arazi
URL:
Keywords: rel_23_11_candidate
Depends on: 31692 33575
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-04 22:35 UTC by Lari Taskula
Modified: 2024-03-25 15:17 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35483: Restore holds table select to switch item level holds to record level holds (3.51 KB, patch)
2023-12-04 22:53 UTC, Lari Taskula
Details | Diff | Splinter Review
Bug 35483: Restore holds table select to switch item level holds to record level holds (3.56 KB, patch)
2023-12-05 16:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35483: (follow-up) Trivial indentation changes (2.81 KB, patch)
2023-12-05 16:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35483: Restore holds table select to switch item level holds to record level holds (3.71 KB, patch)
2023-12-08 11:44 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 35483: (follow-up) Trivial indentation changes (2.96 KB, patch)
2023-12-08 11:44 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 35483: Restore holds table select to switch item level holds to record level holds (3.82 KB, patch)
2024-01-26 18:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35483: (follow-up) Trivial indentation changes (2.78 KB, patch)
2024-01-26 18:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2023-12-04 22:35:47 UTC
Bug 33575 commit [1] has reverted hold level switch feature added in Bug 31692 commit [2] to holds table. Switching item level holds to record level holds no longer works in the table.

Let's restore the feature in this Bug.

[1] https://github.com/Koha-Community/Koha/commit/c649f73d029b406a6bad80c31b8388ba19cdd15c
[2] https://github.com/Koha-Community/Koha/commit/b0f49d5dafa4e2dcc05e1e85c13cde3b66f041f5
Comment 1 Lari Taskula 2023-12-04 22:53:25 UTC
Created attachment 159566 [details] [review]
Bug 35483: Restore holds table select to switch item level holds to record level holds

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown is gone and cell value has changed from
   "Only item <barcode>" to "Next available"
8. Cancel the hold and add two item level holds for the same patron
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown
Comment 2 Owen Leonard 2023-12-05 16:09:12 UTC
Created attachment 159593 [details] [review]
Bug 35483: Restore holds table select to switch item level holds to record level holds

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown is gone and cell value has changed from
   "Only item <barcode>" to "Next available"
8. Cancel the hold and add two item level holds for the same patron
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2023-12-05 16:09:14 UTC
Created attachment 159594 [details] [review]
Bug 35483: (follow-up) Trivial indentation changes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 PTFS Europe Sandboxes 2023-12-08 11:44:42 UTC
Created attachment 159671 [details] [review]
Bug 35483: Restore holds table select to switch item level holds to record level holds

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown is gone and cell value has changed from
   "Only item <barcode>" to "Next available"
8. Cancel the hold and add two item level holds for the same patron
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Comment 5 PTFS Europe Sandboxes 2023-12-08 11:44:44 UTC
Created attachment 159672 [details] [review]
Bug 35483: (follow-up) Trivial indentation changes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Comment 6 Tomás Cohen Arazi 2024-01-25 20:03:52 UTC
Certainly a bad rebase.
Comment 7 Lucas Gass 2024-01-25 23:14:26 UTC
Merge conflicts in holds_table.inc.
Comment 8 Tomás Cohen Arazi 2024-01-26 18:11:11 UTC
Created attachment 161552 [details] [review]
Bug 35483: Restore holds table select to switch item level holds to record level holds

To test:
1. Apply patch
2. Add item level hold to a record/item, make sure patron has no other
   holds on that record
3. Go to /cgi-bin/koha/reserve/request.pl?biblionumber=xxx where xxx is
   the record you placed the hold for
4. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>" dropdown
5. Select "Next available" from the dropdown
6. Click Update hold(s)
7. Observe dropdown is gone and cell value has changed from
   "Only item <barcode>" to "Next available"
8. Cancel the hold and add two item level holds for the same patron
9. Under "Existing holds" table, in "Details" column you should see
   "Only item <barcode>", but no select dropdown

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 9 Tomás Cohen Arazi 2024-01-26 18:11:14 UTC
Created attachment 161553 [details] [review]
Bug 35483: (follow-up) Trivial indentation changes

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 10 Katrin Fischer 2024-01-30 16:50:16 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2024-02-01 16:29:06 UTC
Pushed to 23.11.x for 23.11.03