Bug 35491 - Reverting waiting status for holds is not logged
Summary: Reverting waiting status for holds is not logged
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
: 30217 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-05 16:27 UTC by Nick Clemens (kidclamp)
Modified: 2024-05-01 14:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02,23.05.08


Attachments
Bug 35491: Add logging to RevertWaitingStatus (3.48 KB, patch)
2023-12-05 16:35 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 35491: Add logging to RevertWaitingStatus (3.54 KB, patch)
2023-12-05 18:01 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35491: Add logging to RevertWaitingStatus (3.59 KB, patch)
2023-12-15 20:08 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-12-05 16:27:34 UTC
We should capture the modification of the hold when this is done
Comment 1 Nick Clemens (kidclamp) 2023-12-05 16:35:49 UTC
Created attachment 159595 [details] [review]
Bug 35491: Add logging to RevertWaitingStatus

This patch simply adds a logaction line to RevertWaitingStatus

To test:
1 - Enable HoldsLog
2 - Place a hold
3 - Fill the hold
4 - Revert the waiting status
5 - Note there is no action log added
6 - Apply patch
7 - Repeat 2-4
8 - Confirm you now have a MODIFY action logged for the reversion
Comment 2 ByWater Sandboxes 2023-12-05 18:01:43 UTC
Created attachment 159604 [details] [review]
Bug 35491: Add logging to RevertWaitingStatus

This patch simply adds a logaction line to RevertWaitingStatus

To test:
1 - Enable HoldsLog
2 - Place a hold
3 - Fill the hold
4 - Revert the waiting status
5 - Note there is no action log added
6 - Apply patch
7 - Repeat 2-4
8 - Confirm you now have a MODIFY action logged for the reversion

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Comment 3 Victor Grousset/tuxayo 2023-12-15 20:08:38 UTC
Created attachment 159903 [details] [review]
Bug 35491: Add logging to RevertWaitingStatus

This patch simply adds a logaction line to RevertWaitingStatus

To test:
1 - Enable HoldsLog
2 - Place a hold
3 - Fill the hold
4 - Revert the waiting status
5 - Note there is no action log added
6 - Apply patch
7 - Repeat 2-4
8 - Confirm you now have a MODIFY action logged for the reversion

Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 4 Victor Grousset/tuxayo 2023-12-15 20:10:11 UTC
About the HoldsLog syspref it's description says:
>  any actions on holds (create, cancel, suspend, resume, etc). 

I would say that there is no need to mention revert thanks to the "etc". Just mentioning that here in case that would actually be important to change.


Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 5 Katrin Fischer 2023-12-19 12:44:10 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 15:09:11 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-04 20:49:02 UTC
Backported to 23.05.x for upcoming 23.05.08
Comment 8 Lisette Scheer 2024-05-01 14:12:22 UTC
*** Bug 30217 has been marked as a duplicate of this bug. ***