Bug 35523 - Fix doubled up quotes in cash register deletion confirmation message
Summary: Fix doubled up quotes in cash register deletion confirmation message
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-10 13:19 UTC by Katrin Fischer
Modified: 2024-01-04 20:13 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02
Circulation function:


Attachments
Bug 35523: Fix doubled up quotes in cash register title (1.31 KB, patch)
2023-12-10 13:23 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35523: Fix doubled up quotes in cash register title (1.36 KB, patch)
2023-12-11 09:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 35523: Fix doubled up quotes in cash register title (1.42 KB, patch)
2023-12-18 11:46 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-12-10 13:19:24 UTC

    
Comment 1 Katrin Fischer 2023-12-10 13:23:21 UTC
Created attachment 159695 [details] [review]
Bug 35523: Fix doubled up quotes in cash register title

Updates ''{cash_register}'' to '{cash_register}'

To test:
I believe this is not actually testable, as cash registers
can only be archived and not deleted?
Comment 2 Katrin Fischer 2023-12-10 13:24:09 UTC
This is a bit of an odd one, as we have code and strings for cash register deletion, but I believe this is not possible via the GUI?
Comment 3 David Nind 2023-12-11 09:35:41 UTC
Created attachment 159707 [details] [review]
Bug 35523: Fix doubled up quotes in cash register title

Updates ''{cash_register}'' to '{cash_register}'

To test:
I believe this is not actually testable, as cash registers
can only be archived and not deleted?

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-12-11 09:37:23 UTC
(In reply to Katrin Fischer from comment #2)
> This is a bit of an odd one, as we have code and strings for cash register
> deletion, but I believe this is not possible via the GUI?

I think that is the case. Deleting a cash register is not possible in the UI.

Signing off based on reading the patch.
Comment 5 Tomás Cohen Arazi (tcohen) 2023-12-18 11:46:10 UTC
Created attachment 159952 [details] [review]
Bug 35523: Fix doubled up quotes in cash register title

Updates ''{cash_register}'' to '{cash_register}'

To test:
I believe this is not actually testable, as cash registers
can only be archived and not deleted?

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Katrin Fischer 2023-12-18 14:25:40 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 7 Fridolin Somers 2024-01-03 14:21:41 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Lucas Gass (lukeg) 2024-01-04 20:13:37 UTC
Not needed in 23.05.x, no backport.