Bug 35525 - Spelling: SMS is an abbreviation
Summary: Spelling: SMS is an abbreviation
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-10 13:35 UTC by Katrin Fischer
Modified: 2024-01-04 20:16 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC (3.46 KB, patch)
2023-12-10 13:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC (4.89 KB, patch)
2023-12-10 15:31 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC (4.94 KB, patch)
2023-12-11 10:11 UTC, David Nind
Details | Diff | Splinter Review
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC (4.99 KB, patch)
2023-12-18 11:49 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-12-10 13:35:24 UTC

    
Comment 1 Katrin Fischer 2023-12-10 13:48:10 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2023-12-10 15:31:13 UTC
Created attachment 159701 [details] [review]
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC

Updates sms to SMS.

* Set SMSSendDriver system preference to Email
* Go to the OPAC patron account, messaging tab
* Check some SMS check boxes and save
* Verify that in the source code the aria-label for the
  checked and unchecked checkboxes reads: sms messaging
* Verify that in the source code for the 'days in advance'
  pull down, the message reads "... receive notice"
* Apply patch, restart all
* Verify that the source code for the checked and unchecked
  the aria-label now reads "Select/Unselect SMS messaging"
* Verify that the aria-label on the 'days in advance' pull
  down now reads 'receive the message'

Also fixes a mismatched itiva message.
Repeat test plan with TalkingTechItivaPhoneNotification Enabled
and the phone checkboxes.
Comment 3 David Nind 2023-12-11 10:11:40 UTC
Created attachment 159710 [details] [review]
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC

Updates sms to SMS.

* Set SMSSendDriver system preference to Email
* Go to the OPAC patron account, messaging tab
* Check some SMS check boxes and save
* Verify that in the source code the aria-label for the
  checked and unchecked checkboxes reads: sms messaging
* Verify that in the source code for the 'days in advance'
  pull down, the message reads "... receive notice"
* Apply patch, restart all
* Verify that the source code for the checked and unchecked
  the aria-label now reads "Select/Unselect SMS messaging"
* Verify that the aria-label on the 'days in advance' pull
  down now reads 'receive the message'

Also fixes a mismatched itiva message.
Repeat test plan with TalkingTechItivaPhoneNotification Enabled
and the phone checkboxes.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Tomás Cohen Arazi 2023-12-18 11:49:14 UTC
Created attachment 159953 [details] [review]
Bug 35525: Fix spelling of SMS in aria-labels for messaging in OPAC

Updates sms to SMS.

* Set SMSSendDriver system preference to Email
* Go to the OPAC patron account, messaging tab
* Check some SMS check boxes and save
* Verify that in the source code the aria-label for the
  checked and unchecked checkboxes reads: sms messaging
* Verify that in the source code for the 'days in advance'
  pull down, the message reads "... receive notice"
* Apply patch, restart all
* Verify that the source code for the checked and unchecked
  the aria-label now reads "Select/Unselect SMS messaging"
* Verify that the aria-label on the 'days in advance' pull
  down now reads 'receive the message'

Also fixes a mismatched itiva message.
Repeat test plan with TalkingTechItivaPhoneNotification Enabled
and the phone checkboxes.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Katrin Fischer 2023-12-18 14:25:45 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-03 14:23:44 UTC
Pushed to 23.11.x for 23.11.02
Comment 7 Lucas Gass 2024-01-04 20:16:17 UTC
Doesn't apply cleanly to 23.05.x, no backport.