Bug 35526 - Terminology: Id, sushi and counter are abbreviations
Summary: Terminology: Id, sushi and counter are abbreviations
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-10 13:49 UTC by Katrin Fischer
Modified: 2024-01-04 20:17 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35526: Fix terminology and spelling for ERM data providers (6.65 KB, patch)
2023-12-10 14:03 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 35526: Fix terminology and spelling for ERM data providers (6.70 KB, patch)
2023-12-11 09:17 UTC, David Nind
Details | Diff | Splinter Review
Bug 35526: Fix terminology and spelling for ERM data providers (6.76 KB, patch)
2023-12-18 11:40 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-12-10 13:49:38 UTC

    
Comment 1 Katrin Fischer 2023-12-10 14:03:29 UTC
Created attachment 159698 [details] [review]
Bug 35526: Fix terminology and spelling for ERM data providers

This makes several changes on the form for adding a data provider
and on the data provider details page:

* Enable ERMModule system preference
* Go to the ERM module, add a new data provider
  * Look at the labels on the form
  * Save and check the labels on the summary tab
* Apply patch, run: yarn build
  * Verify fixes
    ...Id => ID
    ...sushi => SUSHI
    ...counter => COUNTER
    ...Report Release => Report release
    ...
Comment 2 David Nind 2023-12-11 09:17:19 UTC
Created attachment 159705 [details] [review]
Bug 35526: Fix terminology and spelling for ERM data providers

This makes several changes on the form for adding a data provider
and on the data provider details page:

* Enable ERMModule system preference
* Go to the ERM module, add a new data provider
  * Look at the labels on the form
  * Save and check the labels on the summary tab
* Apply patch, run: yarn build
  * Verify fixes
    ...Id => ID
    ...sushi => SUSHI
    ...counter => COUNTER
    ...Report Release => Report release
    ...

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Tomás Cohen Arazi 2023-12-18 11:40:45 UTC
Created attachment 159949 [details] [review]
Bug 35526: Fix terminology and spelling for ERM data providers

This makes several changes on the form for adding a data provider
and on the data provider details page:

* Enable ERMModule system preference
* Go to the ERM module, add a new data provider
  * Look at the labels on the form
  * Save and check the labels on the summary tab
* Apply patch, run: yarn build
  * Verify fixes
    ...Id => ID
    ...sushi => SUSHI
    ...counter => COUNTER
    ...Report Release => Report release
    ...

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Katrin Fischer 2023-12-18 14:25:48 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-03 14:24:47 UTC
Pushed to 23.11.x for 23.11.02
Comment 6 Lucas Gass 2024-01-04 20:17:06 UTC
Doesn't apply cleanly to 23.05.x, no backport.