Bug 35530 - Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
Summary: Can't tell if UserCSS and UserJS in libraries are for staff interface or OPAC
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 32721
Blocks:
  Show dependency treegraph
 
Reported: 2023-12-10 15:16 UTC by Katrin Fischer
Modified: 2024-02-01 14:52 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC (2.28 KB, patch)
2024-01-08 13:33 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC (2.33 KB, patch)
2024-01-08 22:10 UTC, David Nind
Details | Diff | Splinter Review
Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC (2.39 KB, patch)
2024-01-25 14:49 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-12-10 15:16:37 UTC
It looks like they are for OPAC, but it's not visible in the library edit form. We should add a hint or rename the options with prefix OPAC.
Comment 1 Fridolin Somers 2024-01-08 13:33:16 UTC
Created attachment 160626 [details] [review]
Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC

In libraries administration new fields UserCSS and UserJS are for OPAC,
this should be in label.

This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help :
Library specific CSS can be defined in ...

Test plan
1) Go to Administration >  Libraries
2) Modify a library
3) Check you see new labels
Comment 2 David Nind 2024-01-08 22:10:21 UTC
Created attachment 160666 [details] [review]
Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC

In libraries administration new fields UserCSS and UserJS are for OPAC,
this should be in label.

This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help :
Library specific CSS can be defined in ...

Test plan
1) Go to Administration >  Libraries
2) Modify a library
3) Check you see new labels

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-01-08 22:17:32 UTC
I don't mind the replacement labels, as they are a great improvement:

- UserJS -> Specific OPAC JS
- UserCSS -> Specific OPAC CSS

Some alternatives:
1. Library specific OPAC JavaScript
   Library specific OPAC CSS
2. Library specific JavaScript for the OPAC
   Library specific CSS for the OPAC
3. OPAC JavaScript for this library
   OPAC CSS for this library

I think I like 3 better, but leaving up to the QA Team.
Comment 4 Katrin Fischer 2024-01-08 22:34:01 UTC
As we are on the library page, I feel like we don't need to point out that it's library specific, all the fields on the page are and it would help to keep the label/hint a bit shorter.
Comment 5 Lucas Gass 2024-01-08 23:12:22 UTC
(In reply to Katrin Fischer from comment #4)
> As we are on the library page, I feel like we don't need to point out that
> it's library specific, all the fields on the page are and it would help to
> keep the label/hint a bit shorter.

I agree.
Comment 6 Martin Renvoize 2024-01-25 14:49:14 UTC
Created attachment 161423 [details] [review]
Bug 35530: Tell UserCSS and UserJS in libraries administration are for OPAC

In libraries administration new fields UserCSS and UserJS are for OPAC,
this should be in label.

This patch uses text "Specific OPAC CSS", since the system preference OPACUserCSS as help :
Library specific CSS can be defined in ...

Test plan
1) Go to Administration >  Libraries
2) Modify a library
3) Check you see new labels

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Katrin Fischer 2024-01-29 11:28:49 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 8 Fridolin Somers 2024-02-01 14:52:20 UTC
Pushed to 23.11.x for 23.11.03