Bug 3554 - Print notices using print css
Summary: Print notices using print css
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-26 12:08 UTC by Nahuel Angelinetti
Modified: 2017-06-14 22:11 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bugfix (10.54 KB, patch)
2009-08-26 12:09 UTC, Chris Cormack
Details | Diff | Splinter Review
head's bugfix (12.23 KB, patch)
2009-08-26 13:32 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:12:04 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2009-08-26 12:08:20 ----

The print link, should use javascript print function, not a popup that is different of the actual view.



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-08-26 12:09:37 ----

Created an attachment
bugfix





---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-08-26 13:32:37 ----

Created an attachment
head's bugfix





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:12 UTC  ---

This bug was previously known as _bug_ 3554 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3554
Imported an attachment (id=1414)
Imported an attachment (id=1415)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1414 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1415 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2010-07-02 17:06:51 UTC
I see this patch has been pushed to HEAD (as part of biblibre-integration I guess), which I think is unfortunate. Here's the comment I made on the patches list at the time:

This breaks the "Print" link for users with JavaScript disabled. I
like the idea of eliminating the dedicated print view, but even if we
had a perfected print stylesheet for the relevant pages I think
usability issues remain with the idea of providing a print view which
is not visible to the user.

Even if the print stylesheet gave a properly-formatted view (and I
would argue it doesn't), how does the average user know that by
printing the page they'll get a print-formatted view? I like that the
dedicated printing page offers that.
Comment 2 Katrin Fischer 2015-06-06 19:31:41 UTC
Owen, is this still valid?