Bug 35634 - Permissions mismatch for vendor issues
Summary: Permissions mismatch for vendor issues
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33105
Blocks:
  Show dependency tree / graph
 
Reported: 2023-12-21 19:28 UTC by Nick Clemens (kidclamp)
Modified: 2024-03-20 12:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02
Circulation function:

Attachments
Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage (2.27 KB, patch)
2024-01-03 13:53 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage (2.32 KB, patch)
2024-01-03 16:13 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage (2.38 KB, patch)
2024-01-05 19:40 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2023-12-21 19:28:56 UTC 
The permissions added to the DB is issue_manage - but in the code we check for issues_manage

git grep issue_manage
git grep issues_manage
issues_manage vs issue_manage
Comment 1 Jonathan Druart 2024-01-03 13:53:49 UTC 
Created attachment 160460 [details] [review]
Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage

issue_manage inserted into the DB but issues_manage is tested in the
controller script.

Test plan:
  git grep issues_manage
should no longer return any results
Comment 2 Lucas Gass (lukeg) 2024-01-03 16:13:38 UTC 
Created attachment 160476 [details] [review]
Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage

issue_manage inserted into the DB but issues_manage is tested in the
controller script.

Test plan:
  git grep issues_manage
should no longer return any results

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2024-01-05 19:40:40 UTC 
Created attachment 160589 [details] [review]
Bug 35634: (bug 33105 follow-up) fix typo issues_manage vs issue_manage

issue_manage inserted into the DB but issues_manage is tested in the
controller script.

Test plan:
  git grep issues_manage
should no longer return any results

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Katrin Fischer 2024-01-11 14:50:12 UTC 
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-15 14:22:43 UTC 
Pushed to 23.11.x for 23.11.02
Comment 6 Lucas Gass (lukeg) 2024-02-02 16:12:16 UTC 
Missing 23.05.x dependencies. NO backport.