The Enquire JS library hasn't been updated for a while, but we're still using an older version. Upgrading to 2.1.6 will bring us to the latest version.
Created attachment 160236 [details] [review] Bug 35638: Upgrade Enquire JS library from v2.0.1 to v2.1.6 This patch upgrades enquire.js in the OPAC to the latest version, v.2.1.6. The patch also moves the file (enquire.min.js) into its own directory for consistency's sake. Enquire.js lets us use CSS-like "breakpoints" to trigger JS actions. We use it to in "mobile" views (narrower browser widths): Collapsing the facets menu and triggering automatic scroll to "main content." The patch also removes media.match.js which should have been removed in Bug 29960. At that time Enquire.js required that we used Modernizr to load media.match.js as a polyfill for older browsers. To test, apply the patch and clear your browser cache if necessary. - In the OPAC, perform a catalog search which will return results. - At wider browser widths the facets menu will appear in the left-hand sidebar. - When you narrow your browser until the viewport is less than 992 pixels wide* the facets menu should collapse into a "Refine your search" button above the search results. - If you narrow your browser width to below 600 pixels wide and reload the search results page, the browser should automatically scroll down so that the "Your search..." heading is at the top of the viewport. * Use Firefox's Responsive Design Mode to get pixel-level control over viewport width: https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/ In Chrome it's called "Device Mode."
Created attachment 160380 [details] [review] Bug 35638: Upgrade Enquire JS library from v2.0.1 to v2.1.6 This patch upgrades enquire.js in the OPAC to the latest version, v.2.1.6. The patch also moves the file (enquire.min.js) into its own directory for consistency's sake. Enquire.js lets us use CSS-like "breakpoints" to trigger JS actions. We use it to in "mobile" views (narrower browser widths): Collapsing the facets menu and triggering automatic scroll to "main content." The patch also removes media.match.js which should have been removed in Bug 29960. At that time Enquire.js required that we used Modernizr to load media.match.js as a polyfill for older browsers. To test, apply the patch and clear your browser cache if necessary. - In the OPAC, perform a catalog search which will return results. - At wider browser widths the facets menu will appear in the left-hand sidebar. - When you narrow your browser until the viewport is less than 992 pixels wide* the facets menu should collapse into a "Refine your search" button above the search results. - If you narrow your browser width to below 600 pixels wide and reload the search results page, the browser should automatically scroll down so that the "Your search..." heading is at the top of the viewport. * Use Firefox's Responsive Design Mode to get pixel-level control over viewport width: https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/ In Chrome it's called "Device Mode." Signed-off-by: David Nind <david@davidnind.com>
Things I noted from testing (using KTD): 1. After the search results, the block for making a purchase suggestion only appears if you are logged in to the OPAC (Block text: Not finding what you're looking for? Make a purchase suggestion). 2. The link in the text under the number of search results, but before the results pagination section, gives you a blank page: - Text is "Not what you expected? Check for suggestions" - 'suggestions' is linked to /cgi-bin/koha/svc/suggestion?render=standalone&q=cat - I have created bug 35676 for this
Created attachment 160935 [details] [review] Bug 35638: Upgrade Enquire JS library from v2.0.1 to v2.1.6 This patch upgrades enquire.js in the OPAC to the latest version, v.2.1.6. The patch also moves the file (enquire.min.js) into its own directory for consistency's sake. Enquire.js lets us use CSS-like "breakpoints" to trigger JS actions. We use it to in "mobile" views (narrower browser widths): Collapsing the facets menu and triggering automatic scroll to "main content." The patch also removes media.match.js which should have been removed in Bug 29960. At that time Enquire.js required that we used Modernizr to load media.match.js as a polyfill for older browsers. To test, apply the patch and clear your browser cache if necessary. - In the OPAC, perform a catalog search which will return results. - At wider browser widths the facets menu will appear in the left-hand sidebar. - When you narrow your browser until the viewport is less than 992 pixels wide* the facets menu should collapse into a "Refine your search" button above the search results. - If you narrow your browser width to below 600 pixels wide and reload the search results page, the browser should automatically scroll down so that the "Your search..." heading is at the top of the viewport. * Use Firefox's Responsive Design Mode to get pixel-level control over viewport width: https://firefox-source-docs.mozilla.org/devtools-user/responsive_design_mode/ In Chrome it's called "Device Mode." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x
Module(?) change, nothing to add/edit in the Koha manual.