Bug 35650 - 'Check the logs' string dot-inconsistent
Summary: 'Check the logs' string dot-inconsistent
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-26 13:36 UTC by Tomás Cohen Arazi
Modified: 2024-01-19 22:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This makes 'Check the logs..' messages more consistent across Koha, including the use of full stops. It also fixes up other related inconsistencies. These changes should make translations easier as well.
Version(s) released in:
24.05.00,23.11.02


Attachments
Bug 35650: Standardize on 'Check the logs for details.' (24.71 KB, patch)
2023-12-26 15:00 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35650: (follow-up) Other cases found (25.05 KB, patch)
2023-12-26 15:00 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 35650: Standardize on 'Check the logs for details.' (24.71 KB, patch)
2023-12-26 21:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 35650: (follow-up) Other cases found (25.06 KB, patch)
2023-12-26 21:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 35650: Standardize on 'Check the logs for details.' (24.82 KB, patch)
2024-01-05 19:38 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 35650: (follow-up) Other cases found (25.15 KB, patch)
2024-01-05 19:38 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2023-12-26 13:36:25 UTC
I found this when translating. If you run:

$ git grep 'Check the logs'

you will notice in most cases the structure is:

<Something happened>. Check the logs.
or
<Something happened>. Check the logs for details

But in some the dot is missing. The inconsistency causes (probably) the constant changes in the translation system in which the same string sometimes has the dot, sometimes it doesn't and it is changed all the time the same way.

I think the correct form is to use the dot, and is also the more widespread. So I'm proposing to stick with using the dot:

$ git grep 'Check the logs' | wc -l
      31

$ git grep 'Check the logs\.' | wc -l
      17

$ git grep 'Check the logs ' | wc -l
      3

$ git grep -e 'Check the logs\"' -e 'Check the logs<' | wc -l
      11
Comment 1 Tomás Cohen Arazi 2023-12-26 15:00:52 UTC
Created attachment 160295 [details] [review]
Bug 35650: Standardize on 'Check the logs for details.'

This patch makes the 'Check the logs..' messages more consistent across
the codebase.

To test:
1. Run:
   $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.'
=> FAIL: Several forms show up
2. Apply this patch
3. Repeat 1
=> SUCCESS: Empty result.
4. Run:
   $ git grep -e 'Check the logs for details\.'
=> SUCCESS: Consisten results show
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Tomás Cohen Arazi 2023-12-26 15:00:54 UTC
Created attachment 160296 [details] [review]
Bug 35650: (follow-up) Other cases found

while editing files for the main patch, I noticed some tiny cases.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 David Nind 2023-12-26 21:39:10 UTC
Created attachment 160303 [details] [review]
Bug 35650: Standardize on 'Check the logs for details.'

This patch makes the 'Check the logs..' messages more consistent across
the codebase.

To test:
1. Run:
   $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.'
=> FAIL: Several forms show up
2. Apply this patch
3. Repeat 1
=> SUCCESS: Empty result.
4. Run:
   $ git grep -e 'Check the logs for details\.'
=> SUCCESS: Consisten results show
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2023-12-26 21:39:13 UTC
Created attachment 160304 [details] [review]
Bug 35650: (follow-up) Other cases found

while editing files for the main patch, I noticed some tiny cases.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-12-26 21:43:03 UTC
A nice tidy up! Thanks Tomás.
Comment 6 Nick Clemens (kidclamp) 2024-01-05 19:38:11 UTC
Created attachment 160587 [details] [review]
Bug 35650: Standardize on 'Check the logs for details.'

This patch makes the 'Check the logs..' messages more consistent across
the codebase.

To test:
1. Run:
   $ git grep -e 'Check the logs\"' -e 'Check the logs<' -e 'Check the logs\.'
=> FAIL: Several forms show up
2. Apply this patch
3. Repeat 1
=> SUCCESS: Empty result.
4. Run:
   $ git grep -e 'Check the logs for details\.'
=> SUCCESS: Consisten results show
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2024-01-05 19:38:13 UTC
Created attachment 160588 [details] [review]
Bug 35650: (follow-up) Other cases found

while editing files for the main patch, I noticed some tiny cases.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Katrin Fischer 2024-01-11 14:50:15 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 9 Fridolin Somers 2024-01-15 14:09:09 UTC
Pushed to 23.11.x for 23.11.02
Comment 10 Lucas Gass 2024-01-19 22:26:08 UTC
Doesn't apply cleanly to 23.05.x, no backport.