Bug 35708 - System parameter AutoRenewalNotices defaults to deprecated option
Summary: System parameter AutoRenewalNotices defaults to deprecated option
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All Linux
: P5 - low minor (vote)
Assignee: Brendan Lawlor
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-05 13:09 UTC by Anke Bruns
Modified: 2024-05-28 17:23 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
NEW INSTALLATIONS ONLY. This sets the default value for the AutoRenewalNotices system preference to "according to patron messaging preferences". (The previous default value was deprecated - "(Deprecated) according to --send-notices cron switch".)
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug: 35708: Update default system preference for AutoRenewalNotices (2.88 KB, patch)
2024-04-03 20:49 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug: 35708: Update default system preference for AutoRenewalNotices (2.93 KB, patch)
2024-04-03 23:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 35708: Update default system preference for AutoRenewalNotices (2.07 KB, patch)
2024-04-04 19:50 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 35708: Update default system preference for AutoRenewalNotices (2.19 KB, patch)
2024-04-04 19:57 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Anke Bruns 2024-01-05 13:09:57 UTC
When installing Koha, the deprecated option "(Deprecated) according to --send-notices cron switch" is set by default in the system preference "AutoRenewalNotices".

It would be nicer to have another option as default, e.g. "according to patron messaging preferences"
Comment 1 Brendan Lawlor 2024-04-03 20:49:34 UTC
Created attachment 164394 [details] [review]
Bug: 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences
Comment 2 David Nind 2024-04-03 23:25:30 UTC
Created attachment 164397 [details] [review]
Bug: 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-04-03 23:30:37 UTC
Testing notes (using KTD):

1. Check the system preference AutoRenewalNotices - note that the default is "(Deprecated) according to --send-notices cron switch".
2. Apply the patch.
3. Reset everything (like it is a new installation): reset_all
4. Note that the AutoRenewalNotices system preference is now set to "according to patron messaging preferences".
Comment 4 Emily Lamancusa 2024-04-04 19:29:48 UTC
Hi Brendan, thanks for catching that! 

Can you please amend your patch to remove the change to updatedatabase.pl? That file is only used for upgrading existing systems older than version 21.05 - it does not generally get edited anymore. The update to sysprefs.sql is all you need in this case. :)

For future reference, this wiki page is a good starting point for making changes to system preferences - https://wiki.koha-community.org/wiki/System_Preferences

And if you're curious, a little history about updatedatabase.pl and how we make database updates now - https://wiki.koha-community.org/wiki/Database_updates#History
Comment 5 Brendan Lawlor 2024-04-04 19:50:51 UTC
Created attachment 164437 [details] [review]
Bug 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences
Comment 6 Brendan Lawlor 2024-04-04 19:56:42 UTC
(In reply to Emily Lamancusa from comment #4)

I had doubts about editing that file after I sent it.

Thanks for the info Emily!
Comment 7 Emily Lamancusa 2024-04-04 19:57:27 UTC
Created attachment 164438 [details] [review]
Bug 35708: Update default system preference for AutoRenewalNotices

Test plan:
1. Apply test plan and restart everything
2. Confirm AutoRenewalNotices defaults to patron messaging preferences

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 8 Emily Lamancusa 2024-04-04 19:59:30 UTC
Thanks for the quick turnaround! Looks good now - passing QA.
Comment 9 Katrin Fischer 2024-04-05 09:31:23 UTC
Good catch, thanks Brendan!
Comment 10 Katrin Fischer 2024-04-05 09:52:25 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 11 Fridolin Somers 2024-05-23 11:45:58 UTC
Pushed to 23.11.x for 23.11.06
Comment 12 Lucas Gass 2024-05-28 17:23:01 UTC
Doesn't apply clean to 23.05.x, no backport.