When installing Koha, the deprecated option "(Deprecated) according to --send-notices cron switch" is set by default in the system preference "AutoRenewalNotices". It would be nicer to have another option as default, e.g. "according to patron messaging preferences"
Created attachment 164394 [details] [review] Bug: 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences
Created attachment 164397 [details] [review] Bug: 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. Check the system preference AutoRenewalNotices - note that the default is "(Deprecated) according to --send-notices cron switch". 2. Apply the patch. 3. Reset everything (like it is a new installation): reset_all 4. Note that the AutoRenewalNotices system preference is now set to "according to patron messaging preferences".
Hi Brendan, thanks for catching that! Can you please amend your patch to remove the change to updatedatabase.pl? That file is only used for upgrading existing systems older than version 21.05 - it does not generally get edited anymore. The update to sysprefs.sql is all you need in this case. :) For future reference, this wiki page is a good starting point for making changes to system preferences - https://wiki.koha-community.org/wiki/System_Preferences And if you're curious, a little history about updatedatabase.pl and how we make database updates now - https://wiki.koha-community.org/wiki/Database_updates#History
Created attachment 164437 [details] [review] Bug 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences
(In reply to Emily Lamancusa from comment #4) I had doubts about editing that file after I sent it. Thanks for the info Emily!
Created attachment 164438 [details] [review] Bug 35708: Update default system preference for AutoRenewalNotices Test plan: 1. Apply test plan and restart everything 2. Confirm AutoRenewalNotices defaults to patron messaging preferences Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Thanks for the quick turnaround! Looks good now - passing QA.
Good catch, thanks Brendan!
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Doesn't apply clean to 23.05.x, no backport.