Bug 35742 - Cannot remove new user added to fund
Summary: Cannot remove new user added to fund
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 35329
  Show dependency treegraph
 
Reported: 2024-01-09 13:46 UTC by Jonathan Druart
Modified: 2024-02-01 14:49 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35742: Fix removal of added user from fund (1.69 KB, patch)
2024-01-09 13:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35742: Fix removal of added user from fund (1.75 KB, patch)
2024-01-09 16:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35742: Fix removal of added user from fund (1.81 KB, patch)
2024-01-17 11:06 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-09 13:46:57 UTC
On the fund edition page, if a new user is added the "Remove" link does not remove the user.
Comment 1 Jonathan Druart 2024-01-09 13:59:16 UTC
Created attachment 160694 [details] [review]
Bug 35742: Fix removal of added user from fund

On the fund edition page, if a new user is added the "Remove" link does not remove the user.

Test plan:
0. Do not apply this patch
1. Edit a fund
2. Click "Add users"
3. Search for patron and add some users
=> Notice that the "Remove" link does not remove the user
4. Apply this patch and repat 1, 2, 3
=> Notice that the "Remove" link remove the user
Comment 2 Owen Leonard 2024-01-09 16:25:01 UTC
Created attachment 160710 [details] [review]
Bug 35742: Fix removal of added user from fund

On the fund edition page, if a new user is added the "Remove" link does
not remove the user.

Test plan:
0. Do not apply this patch
1. Edit a fund
2. Click "Add users"
3. Search for patron and add some users
   => Notice that the "Remove" link does not remove the user
4. Apply this patch and repat 1, 2, 3
   => Notice that the "Remove" link remove the user

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2024-01-17 11:06:55 UTC
Created attachment 161093 [details] [review]
Bug 35742: Fix removal of added user from fund

On the fund edition page, if a new user is added the "Remove" link does
not remove the user.

Test plan:
0. Do not apply this patch
1. Edit a fund
2. Click "Add users"
3. Search for patron and add some users
   => Notice that the "Remove" link does not remove the user
4. Apply this patch and repat 1, 2, 3
   => Notice that the "Remove" link remove the user

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-01-17 11:07:36 UTC
Trivial quoting fix, working now.. Passing QA
Comment 5 Katrin Fischer 2024-01-29 11:29:02 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-01 14:49:21 UTC
Pushed to 23.11.x for 23.11.03