Bug 35745 - Setting suggester on the suggestion edit form does not show library and category
Summary: Setting suggester on the suggestion edit form does not show library and category
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 35744
Blocks: 35329
  Show dependency treegraph
 
Reported: 2024-01-09 13:52 UTC by Jonathan Druart
Modified: 2024-02-01 14:43 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03


Attachments
Bug 35745: Fix 'Set suggester' of a suggestion (2.71 KB, patch)
2024-01-09 14:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35745: Fix 'Set suggester' of a suggestion (2.76 KB, patch)
2024-01-09 16:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35745: Fix 'Set suggester' of a suggestion (2.83 KB, patch)
2024-01-17 10:58 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-01-09 13:52:52 UTC
On the suggestion edit form, if a suggester is selected using the "Set to patron" (and patron search), the details of the selected patron will contained "undefined" for the library's name and patron's category description.
Comment 1 Jonathan Druart 2024-01-09 14:10:34 UTC
Created attachment 160697 [details] [review]
Bug 35745: Fix 'Set suggester' of a suggestion

On the suggestion edit form, if a suggester is selected using the "Set to patron"
(and patron search), the details of the selected patron will contained "undefined"
for the library's name and patron's category description.

Test plan:
Edit a suggestion, click "Set to patron", select a patron
Notice that with this patch the library's name and patron category is
correctly displayed.
Comment 2 Owen Leonard 2024-01-09 16:58:57 UTC
Created attachment 160713 [details] [review]
Bug 35745: Fix 'Set suggester' of a suggestion

On the suggestion edit form, if a suggester is selected using the "Set
to patron" (and patron search), the details of the selected patron will
contained "undefined" for the library's name and patron's category
description.

Test plan:
Edit a suggestion, click "Set to patron", select a patron
Notice that with this patch the library's name and patron category is
correctly displayed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2024-01-17 10:58:42 UTC
Created attachment 161091 [details] [review]
Bug 35745: Fix 'Set suggester' of a suggestion

On the suggestion edit form, if a suggester is selected using the "Set
to patron" (and patron search), the details of the selected patron will
contained "undefined" for the library's name and patron's category
description.

Test plan:
Edit a suggestion, click "Set to patron", select a patron
Notice that with this patch the library's name and patron category is
correctly displayed.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-01-17 11:00:26 UTC
So again, this one all works as expected and qa scripts are happy.. so I'm going to PQA.. however, I am interested in the choice to use +strings as apposed to library/category embeds.
Comment 5 Katrin Fischer 2024-01-29 11:29:11 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-02-01 14:43:36 UTC
Pushed to 23.11.x for 23.11.03