Bug 35759 - Preservation module home yields a blank page
Summary: Preservation module home yields a blank page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Preservation (show other bugs)
Version: Main
Hardware: All All
: P5 - low critical
Assignee: Jonathan Druart
QA Contact: Kyle M Hall (khall)
URL:
Keywords: rel_23_11_candidate
: 36250 (view as bug list)
Depends on: 30708
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-10 13:57 UTC by Nicolas Legrand
Modified: 2024-03-08 19:08 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.02
Circulation function:


Attachments
Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module (1.51 KB, patch)
2024-01-10 14:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module (1.55 KB, patch)
2024-01-12 08:15 UTC, David Nind
Details | Diff | Splinter Review
Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module (1.61 KB, patch)
2024-01-12 14:17 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Legrand 2024-01-10 13:57:43 UTC
Hey,

testing the Preservation module on 23.11 with a Debian package update, but /cgi-bin/koha/preservation/home.pl is blank.

in plack-intranet-error.log one can read:

[WARN] File not found : js/vue/dist/preservation.js at /usr/share/koha/lib/Koha/Template/Plugin/Asset.pm line 84.
Comment 1 Jonathan Druart 2024-01-10 14:03:31 UTC
Created attachment 160767 [details] [review]
Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module

It's missing from the Makefile.PL!

Same as erm.js when need to install it.
Comment 2 David Nind 2024-01-12 08:15:21 UTC
Created attachment 160897 [details] [review]
Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module

It's missing from the Makefile.PL!

Same as erm.js when need to install it.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-01-12 08:17:38 UTC
I've signed off, even though I don't know how to test using KTD.

Feel free to change back to Needs Signoff if there is a way to test using KTD.
Comment 4 Kyle M Hall (khall) 2024-01-12 14:17:59 UTC
Created attachment 160968 [details] [review]
Bug 35759: (bug 30708 follow-up) Generated dist file not installed for preservation module

It's missing from the Makefile.PL!

Same as erm.js when need to install it.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-01-16 11:09:47 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Nicolas Legrand 2024-01-16 13:09:12 UTC
Thank you all!
Comment 7 Fridolin Somers 2024-01-17 09:08:40 UTC
Pushed to 23.11.x for 23.11.02
Comment 8 Tomás Cohen Arazi (tcohen) 2024-03-08 19:08:59 UTC
*** Bug 36250 has been marked as a duplicate of this bug. ***