Bug 35831 - Move UpdateItemLocationOnCheckout to Checkout policy section
Summary: Move UpdateItemLocationOnCheckout to Checkout policy section
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Caroline Cyr La Rose
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-17 21:33 UTC by Caroline Cyr La Rose
Modified: 2024-02-09 20:38 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:


Attachments
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section (5.98 KB, patch)
2024-01-17 21:42 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section (6.03 KB, patch)
2024-01-19 11:57 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section (6.09 KB, patch)
2024-01-23 17:16 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-01-17 21:33:17 UTC
The UpdateItemLocationOnCheckout system preference introduced in bug 21159 has been put under Circulation > Checkin policy. As this affect items on checkout, I think it should go under Circulation > Checkout policy.
Comment 1 Caroline Cyr La Rose 2024-01-17 21:42:31 UTC
Created attachment 161120 [details] [review]
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.
Comment 2 Aude Charillon 2024-01-19 11:56:48 UTC
Works as described: the UpdateItemLocationOnCheckout system preference disappears from the Checkin policy section and correctly appears in the Checkout policy one instead.
Comment 3 PTFS Europe Sandboxes 2024-01-19 11:57:46 UTC
Created attachment 161207 [details] [review]
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

Signed-off-by: Aude <aude.charillon@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-01-23 17:16:09 UTC
Created attachment 161310 [details] [review]
Bug 35831: Move UpdateItemLocationOnCheckout to Checkout policy section

This patch moves the UpdateItemLocationOnCheckout system preference from
the Checkin policy section of the circulation preferences to the
Checkout policy section.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation
3. Check that UpdateItemLocationOnCheckout is under Checkout policy

The text should be the same as before, and the feature should not have changed.

Signed-off-by: Aude <aude.charillon@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-01-26 14:18:18 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-31 14:02:02 UTC
Pushed to 23.11.x for 23.11.03
Comment 7 Lucas Gass 2024-02-09 20:38:00 UTC
Doesn't apply clean to 23.05.x, no backport.