Bug 35841 - Update text of 'Cancel' hold button on OPAC
Summary: Update text of 'Cancel' hold button on OPAC
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-18 23:08 UTC by Lucas Gass (lukeg)
Modified: 2024-02-09 20:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03
Circulation function:


Attachments
Bug 35841: Change wording to indicate request to cancel (2.17 KB, patch)
2024-01-18 23:12 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35841: Change wording to indicate request to cancel (2.22 KB, patch)
2024-01-21 20:59 UTC, David Nind
Details | Diff | Splinter Review
Bug 35841: Change wording to indicate request to cancel (2.29 KB, patch)
2024-01-23 17:13 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-01-18 23:08:24 UTC
On the OPAC, if a hold is waiting one can request to cancel it. However, the wording of the button is misleading. It reads 'Cancel', indicating to patrons that there hold has been canceled. 

It should be 'Request to cancel'.
Comment 1 Lucas Gass (lukeg) 2024-01-18 23:12:41 UTC
Created attachment 161162 [details] [review]
Bug 35841: Change wording to indicate request to cancel

1. APPLY PATCH
2. Update circ rules "Default waiting hold cancellation policy" to allow cancellation of holds.
3. Put some holds onto a patron account, Make some waiting holds and have others be any other status besides waiting.
4. Log in to the OPAC as that patron.
5. Go to your account details and look at the Holds tab.
6. You should see a 'Request to cancel' button for all waiting holds.
7. You should see a 'Cancel' button for all non-waiting holds.
Comment 2 David Nind 2024-01-21 20:59:00 UTC
Created attachment 161226 [details] [review]
Bug 35841: Change wording to indicate request to cancel

1. APPLY PATCH
2. Update circ rules "Default waiting hold cancellation policy" to allow cancellation of holds.
3. Put some holds onto a patron account, Make some waiting holds and have others be any other status besides waiting.
4. Log in to the OPAC as that patron.
5. Go to your account details and look at the Holds tab.
6. You should see a 'Request to cancel' button for all waiting holds.
7. You should see a 'Cancel' button for all non-waiting holds.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2024-01-23 17:13:09 UTC
Created attachment 161308 [details] [review]
Bug 35841: Change wording to indicate request to cancel

1. APPLY PATCH
2. Update circ rules "Default waiting hold cancellation policy" to allow cancellation of holds.
3. Put some holds onto a patron account, Make some waiting holds and have others be any other status besides waiting.
4. Log in to the OPAC as that patron.
5. Go to your account details and look at the Holds tab.
6. You should see a 'Request to cancel' button for all waiting holds.
7. You should see a 'Cancel' button for all non-waiting holds.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-01-26 14:18:23 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-01-31 13:50:49 UTC
Pushed to 23.11.x for 23.11.03
Comment 6 Lucas Gass (lukeg) 2024-02-09 20:25:13 UTC
Doesn't apply clean to 23.05.x, no backport.