Bug 35869 - Dismissing an OPAC message from SCO logs the user out
Summary: Dismissing an OPAC message from SCO logs the user out
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Sam Lau
QA Contact: Matt Blenkinsop
URL:
Keywords:
: 36533 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-22 23:55 UTC by Lucas Gass (lukeg)
Modified: 2024-08-01 00:30 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes the "Dismiss" button for patron messages that appear in the OPAC self-checkout system. Dismissing messages was logging patrons out. This option was removed, as fixing this would require significant changes to the self-checkout system. Patron's can still dismiss messages from their OPAC account (Your account > Summary > Messages for you > Dismiss).
Version(s) released in:
24.11.00,24.05.02,23.11.07
Circulation function:


Attachments
Bug 35869: Removes the dismiss button from messages on OPAC SCO module (4.01 KB, patch)
2024-06-05 18:07 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 35869: Removes the dismiss button from messages on OPAC SCO module (4.06 KB, patch)
2024-06-05 19:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35869: Removes the dismiss button from messages on OPAC SCO module (4.14 KB, patch)
2024-06-07 12:46 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-01-22 23:55:48 UTC
To recreate: 

1. Enable  WebBasedSelfCheck
2. Add an OPAC mesaage to a patron account
3. Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl )
4. Enter your credentials to login
5. See the OPAC message, click dismiss. 
6. Notice you are logged out at redirected to: ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl )
Comment 1 Sam Lau 2024-06-04 19:28:08 UTC
*** Bug 36533 has been marked as a duplicate of this bug. ***
Comment 2 David Cook 2024-06-05 00:03:54 UTC
As I note on bug 36533, it's not really possible to fix this without making some serious changes.

I would recommend just removing the dismiss option from the self-checkout.
Comment 3 Sam Lau 2024-06-05 18:07:04 UTC
Created attachment 167489 [details] [review]
Bug 35869: Removes the dismiss button from messages on OPAC SCO module

This removes the "Dismiss" button from the SCO module. Currently, the
"Dismiss" button is present, however it does not function properly and
logs the user out if they press it. As noted on previous chats, keeping
the button would require serious changes, thus it's easier just to remove
the functionallity.

To test:
1) Enable  WebBasedSelfCheck
2) Add an OPAC mesaage to a patron account
3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl )
4) See the OPAC message, click dismiss.
5) Notice you are logged out at redirected to:
   ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl )
6) Apply patch
7) Log back into the self checkout module
8) Notice that there is no longer a "Dismiss" button for the message.
9) Log into OPAC into the same user's account
10) On the summary page, note that there is still a dismiss button.
11) Ensure this still works properly
12) sign-off
Comment 4 Lucas Gass (lukeg) 2024-06-05 19:57:44 UTC
Created attachment 167495 [details] [review]
Bug 35869: Removes the dismiss button from messages on OPAC SCO module

This removes the "Dismiss" button from the SCO module. Currently, the
"Dismiss" button is present, however it does not function properly and
logs the user out if they press it. As noted on previous chats, keeping
the button would require serious changes, thus it's easier just to remove
the functionallity.

To test:
1) Enable  WebBasedSelfCheck
2) Add an OPAC mesaage to a patron account
3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl )
4) See the OPAC message, click dismiss.
5) Notice you are logged out at redirected to:
   ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl )
6) Apply patch
7) Log back into the self checkout module
8) Notice that there is no longer a "Dismiss" button for the message.
9) Log into OPAC into the same user's account
10) On the summary page, note that there is still a dismiss button.
11) Ensure this still works properly
12) sign-off

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Matt Blenkinsop 2024-06-07 12:46:25 UTC
Created attachment 167574 [details] [review]
Bug 35869: Removes the dismiss button from messages on OPAC SCO module

This removes the "Dismiss" button from the SCO module. Currently, the
"Dismiss" button is present, however it does not function properly and
logs the user out if they press it. As noted on previous chats, keeping
the button would require serious changes, thus it's easier just to remove
the functionallity.

To test:
1) Enable  WebBasedSelfCheck
2) Add an OPAC mesaage to a patron account
3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl )
4) See the OPAC message, click dismiss.
5) Notice you are logged out at redirected to:
   ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl )
6) Apply patch
7) Log back into the self checkout module
8) Notice that there is no longer a "Dismiss" button for the message.
9) Log into OPAC into the same user's account
10) On the summary page, note that there is still a dismiss button.
11) Ensure this still works properly
12) sign-off

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2024-06-11 10:56:16 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 7 Lucas Gass (lukeg) 2024-07-10 16:57:33 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 8 Fridolin Somers 2024-07-17 14:11:26 UTC
Pushed to 23.11.x for 23.11.07
Comment 9 Wainui Witika-Park 2024-07-19 03:39:04 UTC
not backporting to 23.05.x unless requested