To recreate: 1. Enable WebBasedSelfCheck 2. Add an OPAC mesaage to a patron account 3. Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl ) 4. Enter your credentials to login 5. See the OPAC message, click dismiss. 6. Notice you are logged out at redirected to: ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl )
*** Bug 36533 has been marked as a duplicate of this bug. ***
As I note on bug 36533, it's not really possible to fix this without making some serious changes. I would recommend just removing the dismiss option from the self-checkout.
Created attachment 167489 [details] [review] Bug 35869: Removes the dismiss button from messages on OPAC SCO module This removes the "Dismiss" button from the SCO module. Currently, the "Dismiss" button is present, however it does not function properly and logs the user out if they press it. As noted on previous chats, keeping the button would require serious changes, thus it's easier just to remove the functionallity. To test: 1) Enable WebBasedSelfCheck 2) Add an OPAC mesaage to a patron account 3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl ) 4) See the OPAC message, click dismiss. 5) Notice you are logged out at redirected to: ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl ) 6) Apply patch 7) Log back into the self checkout module 8) Notice that there is no longer a "Dismiss" button for the message. 9) Log into OPAC into the same user's account 10) On the summary page, note that there is still a dismiss button. 11) Ensure this still works properly 12) sign-off
Created attachment 167495 [details] [review] Bug 35869: Removes the dismiss button from messages on OPAC SCO module This removes the "Dismiss" button from the SCO module. Currently, the "Dismiss" button is present, however it does not function properly and logs the user out if they press it. As noted on previous chats, keeping the button would require serious changes, thus it's easier just to remove the functionallity. To test: 1) Enable WebBasedSelfCheck 2) Add an OPAC mesaage to a patron account 3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl ) 4) See the OPAC message, click dismiss. 5) Notice you are logged out at redirected to: ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl ) 6) Apply patch 7) Log back into the self checkout module 8) Notice that there is no longer a "Dismiss" button for the message. 9) Log into OPAC into the same user's account 10) On the summary page, note that there is still a dismiss button. 11) Ensure this still works properly 12) sign-off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 167574 [details] [review] Bug 35869: Removes the dismiss button from messages on OPAC SCO module This removes the "Dismiss" button from the SCO module. Currently, the "Dismiss" button is present, however it does not function properly and logs the user out if they press it. As noted on previous chats, keeping the button would require serious changes, thus it's easier just to remove the functionallity. To test: 1) Enable WebBasedSelfCheck 2) Add an OPAC mesaage to a patron account 3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl ) 4) See the OPAC message, click dismiss. 5) Notice you are logged out at redirected to: ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl ) 6) Apply patch 7) Log back into the self checkout module 8) Notice that there is no longer a "Dismiss" button for the message. 9) Log into OPAC into the same user's account 10) On the summary page, note that there is still a dismiss button. 11) Ensure this still works properly 12) sign-off Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.02
Pushed to 23.11.x for 23.11.07
not backporting to 23.05.x unless requested