Building on Bug 35877, this patch will update the patrons requesting modifications page (members-update.pl) to use WRAPPERs to generate the Bootstrap accordion markup.
Created attachment 161329 [details] [review] Bug 35880: Use template wrapper for accordions: Patrons requesting modifications This patch updates the patrons requesting modification page so that Bootstrap accordion markup is generated by WRAPPERs. To test, apply the patch and make sure you have the OPACPatronDetails system preference enabled. - Create at least two different patron modification requests: - Log in to the OPAC using two different patron accounts, each time following the sidebar link for "Personal details." - Make some changes to the patron records and submit them. - In the staff interface, from the home page, click the "Patrons requesting modifications" link. - You should see the list of updates in the same format as before: Collapsible panels where clicking the patron name heading expands the corresponding information. - View the detail or checkout page for one of your updated patrons. - Click the "Review pending modifications" link. - The modifications page should open with that patron's information exapanded.
Created attachment 161737 [details] [review] Bug 35880: Use template wrapper for accordions: Patrons requesting modifications This patch updates the patrons requesting modification page so that Bootstrap accordion markup is generated by WRAPPERs. To test, apply the patch and make sure you have the OPACPatronDetails system preference enabled. - Create at least two different patron modification requests: - Log in to the OPAC using two different patron accounts, each time following the sidebar link for "Personal details." - Make some changes to the patron records and submit them. - In the staff interface, from the home page, click the "Patrons requesting modifications" link. - You should see the list of updates in the same format as before: Collapsible panels where clicking the patron name heading expands the corresponding information. - View the detail or checkout page for one of your updated patrons. - Click the "Review pending modifications" link. - The modifications page should open with that patron's information exapanded. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 163723 [details] [review] Bug 35880: Use template wrapper for accordions: Patrons requesting modifications This patch updates the patrons requesting modification page so that Bootstrap accordion markup is generated by WRAPPERs. To test, apply the patch and make sure you have the OPACPatronDetails system preference enabled. - Create at least two different patron modification requests: - Log in to the OPAC using two different patron accounts, each time following the sidebar link for "Personal details." - Make some changes to the patron records and submit them. - In the staff interface, from the home page, click the "Patrons requesting modifications" link. - You should see the list of updates in the same format as before: Collapsible panels where clicking the patron name heading expands the corresponding information. - View the detail or checkout page for one of your updated patrons. - Click the "Review pending modifications" link. - The modifications page should open with that patron's information exapanded. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 163888 [details] [review] Bug 35880: Use template wrapper for accordions: Patrons requesting modifications This patch updates the patrons requesting modification page so that Bootstrap accordion markup is generated by WRAPPERs. To test, apply the patch and make sure you have the OPACPatronDetails system preference enabled. - Create at least two different patron modification requests: - Log in to the OPAC using two different patron accounts, each time following the sidebar link for "Personal details." - Make some changes to the patron records and submit them. - In the staff interface, from the home page, click the "Patrons requesting modifications" link. - You should see the list of updates in the same format as before: Collapsible panels where clicking the patron name heading expands the corresponding information. - View the detail or checkout page for one of your updated patrons. - Click the "Review pending modifications" link. - The modifications page should open with that patron's information exapanded. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Hm, dependency is enhancement, but the depending bugs are normal - should this be backported?
Pushed for 24.05! Well done everyone, thank you!
Enhancement not backported
Code structure change, nothing to add/edit in the manual.