Bug 35894 - Duplicate link in booksellers.tt
Summary: Duplicate link in booksellers.tt
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Matt Blenkinsop
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on:
Blocks: 34647
  Show dependency treegraph
 
Reported: 2024-01-24 14:08 UTC by Matt Blenkinsop
Modified: 2024-02-08 18:58 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.03,23.05.09


Attachments
Bug 35894: Remove duplicate link (1.54 KB, patch)
2024-01-24 14:11 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 35894: Remove duplicate link (1.58 KB, patch)
2024-01-24 16:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35894: Remove duplicate link (1.64 KB, patch)
2024-01-25 15:37 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-01-24 14:08:42 UTC
There is a duplicated link in booksellers.tt which has no apparent function.
Comment 1 Matt Blenkinsop 2024-01-24 14:11:51 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-01-24 16:16:01 UTC
Created attachment 161350 [details] [review]
Bug 35894: Remove duplicate link

This patch deletes a link that appears to be an unnecessary duplicate
in the template file. The link does not appear in the UI and serves no
obvious purpose

Test plan:
1) Navigate to Acquisitions and click Search next to the vendors field
2) Click on a vendor name and the navigation should still work as
   intended, taking you to the Vendor's details page.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Martin Renvoize 2024-01-25 15:37:56 UTC
Created attachment 161431 [details] [review]
Bug 35894: Remove duplicate link

This patch deletes a link that appears to be an unnecessary duplicate
in the template file. The link does not appear in the UI and serves no
obvious purpose

Test plan:
1) Navigate to Acquisitions and click Search next to the vendors field
2) Click on a vendor name and the navigation should still work as
   intended, taking you to the Vendor's details page.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2024-01-25 15:38:18 UTC
Good spot, Passing QA
Comment 5 Katrin Fischer 2024-01-26 14:18:35 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-01-31 13:07:27 UTC
Pushed to 23.11.x for 23.11.03
Comment 7 Lucas Gass 2024-02-08 18:58:30 UTC
Backported to 23.05.x for upcoming 23.05.09.