Bug 35895 - Reindent tags review template
Summary: Reindent tags review template
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Kyle M Hall (khall)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-24 14:27 UTC by Owen Leonard
Modified: 2024-07-04 18:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:


Attachments
Bug 35895: (follow-up) Add markup comments (4.53 KB, patch)
2024-01-24 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: Reindent tags review template (37.55 KB, patch)
2024-01-24 14:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: (follow-up) Add markup comments (4.53 KB, patch)
2024-01-24 14:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: Reindent tags review template (37.66 KB, patch)
2024-02-07 18:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: (follow-up) Add markup comments (4.53 KB, patch)
2024-02-07 18:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: Reindent tags review template (37.72 KB, patch)
2024-02-08 14:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35895: (follow-up) Add markup comments (4.64 KB, patch)
2024-02-08 14:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 35895: Reindent tags review template (37.04 KB, patch)
2024-03-19 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: (follow-up) Add markup comments (4.23 KB, patch)
2024-03-19 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35895: Reindent tags review template (37.09 KB, patch)
2024-03-22 09:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 35895: (follow-up) Add markup comments (4.28 KB, patch)
2024-03-22 09:44 UTC, David Nind
Details | Diff | Splinter Review
Bug 35895: Reindent tags review template (37.14 KB, patch)
2024-05-03 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 35895: (follow-up) Add markup comments (4.33 KB, patch)
2024-05-03 14:43 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-01-24 14:27:39 UTC
I would like to update tabs/review.tt so that it has consistent indentation.
Comment 1 Owen Leonard 2024-01-24 14:43:31 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-01-24 14:44:21 UTC
Created attachment 161340 [details] [review]
Bug 35895: Reindent tags review template

This patch reindents the tags review template so that it has consistent
indentation, with tab indentation coverted to space.

The patch also adds "FILTER collapse" around the <style> block in the
head of the page.

To test, apply the patch and go to Tools -> Tags.

 - The page should look unchanged.
 - Test that no functionality has been affected:
   - Tag searches
   - Tag status changes
   - Check lists
- If you view the diff while ignoring whitespace the only changes should
  be places where line breaks were introduced.
Comment 3 Owen Leonard 2024-01-24 14:44:23 UTC
Created attachment 161341 [details] [review]
Bug 35895: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 4 Owen Leonard 2024-02-07 18:23:36 UTC
Created attachment 161845 [details] [review]
Bug 35895: Reindent tags review template

This patch reindents the tags review template so that it has consistent
indentation, with tab indentation coverted to space.

The patch also adds "FILTER collapse" around the <style> block in the
head of the page.

To test, apply the patch and go to Tools -> Tags.

 - The page should look unchanged.
 - Test that no functionality has been affected:
   - Tag searches
   - Tag status changes
   - Check lists
- If you view the diff while ignoring whitespace the only changes should
  be places where line breaks were introduced.
Comment 5 Owen Leonard 2024-02-07 18:23:38 UTC
Created attachment 161846 [details] [review]
Bug 35895: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 6 Pedro Amorim 2024-02-08 14:24:45 UTC
Created attachment 161916 [details] [review]
Bug 35895: Reindent tags review template

This patch reindents the tags review template so that it has consistent
indentation, with tab indentation coverted to space.

The patch also adds "FILTER collapse" around the <style> block in the
head of the page.

To test, apply the patch and go to Tools -> Tags.

 - The page should look unchanged.
 - Test that no functionality has been affected:
   - Tag searches
   - Tag status changes
   - Check lists
- If you view the diff while ignoring whitespace the only changes should
  be places where line breaks were introduced.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 7 Pedro Amorim 2024-02-08 14:24:48 UTC
Created attachment 161917 [details] [review]
Bug 35895: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

PA ammended: IF message_loo -> IF message_loop

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 8 Owen Leonard 2024-03-19 15:14:42 UTC
Created attachment 163454 [details] [review]
Bug 35895: Reindent tags review template

This patch reindents the tags review template so that it has consistent
indentation, with tab indentation coverted to space.

The patch also adds "FILTER collapse" around the <style> block in the
head of the page.

To test, apply the patch and go to Tools -> Tags.

 - The page should look unchanged.
 - Test that no functionality has been affected:
   - Tag searches
   - Tag status changes
   - Check lists
- If you view the diff while ignoring whitespace the only changes should
  be places where line breaks were introduced
Comment 9 Owen Leonard 2024-03-19 15:14:44 UTC
Created attachment 163455 [details] [review]
Bug 35895: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.
Comment 10 David Nind 2024-03-22 09:44:07 UTC
Created attachment 163666 [details] [review]
Bug 35895: Reindent tags review template

This patch reindents the tags review template so that it has consistent
indentation, with tab indentation coverted to space.

The patch also adds "FILTER collapse" around the <style> block in the
head of the page.

To test, apply the patch and go to Tools -> Tags.

 - The page should look unchanged.
 - Test that no functionality has been affected:
   - Tag searches
   - Tag status changes
   - Check lists
- If you view the diff while ignoring whitespace the only changes should
  be places where line breaks were introduced

Signed-off-by: David Nind <david@davidnind.com>
Comment 11 David Nind 2024-03-22 09:44:10 UTC
Created attachment 163667 [details] [review]
Bug 35895: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Comment 12 Kyle M Hall (khall) 2024-05-03 14:43:28 UTC
Created attachment 166144 [details] [review]
Bug 35895: Reindent tags review template

This patch reindents the tags review template so that it has consistent
indentation, with tab indentation coverted to space.

The patch also adds "FILTER collapse" around the <style> block in the
head of the page.

To test, apply the patch and go to Tools -> Tags.

 - The page should look unchanged.
 - Test that no functionality has been affected:
   - Tag searches
   - Tag status changes
   - Check lists
- If you view the diff while ignoring whitespace the only changes should
  be places where line breaks were introduced

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 13 Kyle M Hall (khall) 2024-05-03 14:43:34 UTC
Created attachment 166145 [details] [review]
Bug 35895: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the page's appearance or
functionality.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 14 Katrin Fischer 2024-05-06 07:13:08 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 15 Fridolin Somers 2024-05-24 13:24:54 UTC
Not backported to 23.11.x
Comment 16 Caroline Cyr La Rose 2024-07-04 18:18:06 UTC
Code structure change, nothing to add/edit in the manual.