Bug 35934 - Items in transit show as both in-transit and Available on holdings list
Summary: Items in transit show as both in-transit and Available on holdings list
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Emily Lamancusa
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 35696
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-29 20:22 UTC by Emily Lamancusa
Modified: 2024-03-20 22:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10


Attachments
Bug 35934: Correct missed case of switching items.transfer to transfer in detail.tt (1.74 KB, patch)
2024-01-29 20:31 UTC, Emily Lamancusa
Details | Diff | Splinter Review
Bug 35934: Correct missed case of switching items.transfer to transfer in detail.tt (1.79 KB, patch)
2024-01-31 16:23 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35934: Correct missed case of switching items.transfer to transfer in detail.tt (1.89 KB, patch)
2024-03-15 10:03 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa 2024-01-29 20:22:01 UTC
Like bug 35696, this is another missed case where items.transfer should have been switched to transfer in the template.
Comment 1 Emily Lamancusa 2024-01-29 20:31:22 UTC
Created attachment 161615 [details] [review]
Bug 35934: Correct missed case of switching items.transfer to transfer in detail.tt

To test:
1. Put an item with no holds/recalls in transit (manually or by checking
  it in at a branch other than its homebranch to trigger a ReturnToHome)
2. Go to the item's bib record
--> Note that the item's status will display as something like,
    "In transit from X to Y since 01/29/2024 Available"
3. Apply patch and refresh the page
--> Note that item now shows only the transit status, but not "Available"
Comment 2 Lucas Gass 2024-01-31 16:23:40 UTC
Created attachment 161698 [details] [review]
Bug 35934: Correct missed case of switching items.transfer to transfer in detail.tt

To test:
1. Put an item with no holds/recalls in transit (manually or by checking
  it in at a branch other than its homebranch to trigger a ReturnToHome)
2. Go to the item's bib record
--> Note that the item's status will display as something like,
    "In transit from X to Y since 01/29/2024 Available"
3. Apply patch and refresh the page
--> Note that item now shows only the transit status, but not "Available"

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Marcel de Rooy 2024-03-15 10:03:21 UTC
Created attachment 163185 [details] [review]
Bug 35934: Correct missed case of switching items.transfer to transfer in detail.tt

To test:
1. Put an item with no holds/recalls in transit (manually or by checking
  it in at a branch other than its homebranch to trigger a ReturnToHome)
2. Go to the item's bib record
--> Note that the item's status will display as something like,
    "In transit from X to Y since 01/29/2024 Available"
3. Apply patch and refresh the page
--> Note that item now shows only the transit status, but not "Available"

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-03-15 14:40:14 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-03-18 09:23:46 UTC
Pushed to 23.11.x for 23.11.04
Comment 6 Lucas Gass 2024-03-19 21:48:56 UTC
Backported to 23.05.x for upcoming 23.05.10