Bug 35952 - Removed unnecessary line in opac-blocked.pl
Summary: Removed unnecessary line in opac-blocked.pl
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Julian Maurice
URL:
Keywords:
Depends on: 34894
Blocks:
  Show dependency treegraph
 
Reported: 2024-01-30 20:36 UTC by Lucas Gass
Modified: 2024-03-19 15:28 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.04,23.05.10


Attachments
Bug 35952: Remove unnecessary line for OpacSuppressionMessage (1.05 KB, patch)
2024-01-30 20:40 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 35952: Remove unnecessary line for OpacSuppressionMessage (1.11 KB, patch)
2024-01-31 13:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 35952: Remove unnecessary line for OpacSuppressionMessage (1.17 KB, patch)
2024-02-16 09:59 UTC, Julian Maurice
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-01-30 20:36:34 UTC
-$template->param ( OpacSuppressionMessage => C4::Context->preference('OpacSuppressionMessage'));

This line is useless now that OpacSuppressionMessage comes from additional_contents, not a sys pref.
Comment 1 Lucas Gass 2024-01-30 20:40:59 UTC
Created attachment 161662 [details] [review]
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

To test:
1. Apply patch and restart all
2. Add an additional contetn entry for `OpacSuppressionMessage`, make sure it has a publication date in the past.
3. Make sure  OpacSuppression is set to 'hide'.
4. Suppress a record in the OPAC, ( 942$n )
5. Visit the detail page for that record and make sure you OpacSuppressionMessage customization displays.
Comment 2 Owen Leonard 2024-01-31 13:02:01 UTC
Created attachment 161681 [details] [review]
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

To test:
1. Apply patch and restart all
2. Add an additional contetn entry for `OpacSuppressionMessage`, make
   sure it has a publication date in the past.
3. Make sure  OpacSuppression is set to 'hide'.
4. Suppress a record in the OPAC, ( 942$n )
5. Visit the detail page for that record and make sure you
   OpacSuppressionMessage customization displays.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Julian Maurice 2024-02-16 09:59:28 UTC
Created attachment 162237 [details] [review]
Bug 35952: Remove unnecessary line for OpacSuppressionMessage

To test:
1. Apply patch and restart all
2. Add an additional contetn entry for `OpacSuppressionMessage`, make
   sure it has a publication date in the past.
3. Make sure  OpacSuppression is set to 'hide'.
4. Suppress a record in the OPAC, ( 942$n )
5. Visit the detail page for that record and make sure you
   OpacSuppressionMessage customization displays.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 4 Katrin Fischer 2024-03-07 14:04:11 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Fridolin Somers 2024-03-11 09:41:44 UTC
Bug 34894 moved preference to HTML customization
Comment 6 Fridolin Somers 2024-03-11 09:42:12 UTC
Pushed to 23.11.x for 23.11.04
Comment 7 Lucas Gass 2024-03-19 15:28:14 UTC
Backported to 23.05.x for upcoming 23.05.10