With the introduction to bug 12532, Copy guarantee email to the guarantor (or redirect if guarantee has no email set), a new system preference has been included in Koha, EnableRedirectGuaranteeEmail. Unfortunately, although the system preference choices on the interface say Enable/Don't Enable, the code has a Yes/No value. koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref This will need to be fixed to align with Koha is looking for to turn on this sys pref.
Created attachment 163289 [details] [review] Bug 35973: Correct wrong values for RedirectGuaranteeEmail system preference The system preferences was added with 0/1 in sysprefs.sql is checked as boolean. But the .pref file was added with yes/no which both evaluate as strings to true. This fixes the .pref file and includes a database update that sets 0 and 1 correctly for the value currently chosen in the pref. To test: * Make sure to update RedirectGuaranteeEmail to Enable/Don't enable before applying the patch * Verify in the database, that the values was set to yes or no You can use a report like: SELECT * from systempreferences WHERE variable = "RedirectGuaranteeEmail"; * Apply patch and run database update * Verify the value in the database was corrected: Yes = 1, No = 0 * Change the setting, verify the new value is stored correctly
Created attachment 163725 [details] [review] Bug 35973: Correct wrong values for RedirectGuaranteeEmail system preference The system preferences was added with 0/1 in sysprefs.sql is checked as boolean. But the .pref file was added with yes/no which both evaluate as strings to true. This fixes the .pref file and includes a database update that sets 0 and 1 correctly for the value currently chosen in the pref. To test: * Make sure to update RedirectGuaranteeEmail to Enable/Don't enable before applying the patch * Verify in the database, that the values was set to yes or no You can use a report like: SELECT * from systempreferences WHERE variable = "RedirectGuaranteeEmail"; * Apply patch and run database update * Verify the value in the database was corrected: Yes = 1, No = 0 * Change the setting, verify the new value is stored correctly Signed-off-by: David Nind <david@davidnind.com>
Created attachment 165173 [details] [review] Bug 35973: Correct wrong values for RedirectGuaranteeEmail system preference The system preferences was added with 0/1 in sysprefs.sql is checked as boolean. But the .pref file was added with yes/no which both evaluate as strings to true. This fixes the .pref file and includes a database update that sets 0 and 1 correctly for the value currently chosen in the pref. To test: * Make sure to update RedirectGuaranteeEmail to Enable/Don't enable before applying the patch * Verify in the database, that the values was set to yes or no You can use a report like: SELECT * from systempreferences WHERE variable = "RedirectGuaranteeEmail"; * Apply patch and run database update * Verify the value in the database was corrected: Yes = 1, No = 0 * Change the setting, verify the new value is stored correctly Signed-off-by: David Nind <david@davidnind.com>
Created attachment 165174 [details] [review] Bug 35973: (QA follow-up) Ad exec flag to update
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Missing 23.05.x dependencies, no backport.