Bug 35996 - Add clarification to POD in writeoff_debts.pl
Summary: Add clarification to POD in writeoff_debts.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 35074
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-05 16:49 UTC by Matt Blenkinsop
Modified: 2024-05-28 20:45 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 35996: Make it clear that --category-code can not be used alone (1.51 KB, patch)
2024-02-05 16:53 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 35996: Make it clear that --category-code can not be used alone (1.54 KB, patch)
2024-02-05 20:35 UTC, David Nind
Details | Diff | Splinter Review
Bug 35996: Make it clear that --category-code can not be used alone (1.91 KB, patch)
2024-04-12 09:57 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-02-05 16:49:33 UTC

    
Comment 1 Matt Blenkinsop 2024-02-05 16:53:53 UTC
Created attachment 161764 [details] [review]
Bug 35996: Make it clear that --category-code can not be used alone

This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters

Test plan:
1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm
2) Observe that the help menu is displayed instead of running the script
3) Check the help menu for the text added in this patch
Comment 2 David Nind 2024-02-05 20:35:48 UTC
Created attachment 161770 [details] [review]
Bug 35996: Make it clear that --category-code can not be used alone

This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters

Test plan:
1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm
2) Observe that the help menu is displayed instead of running the script
3) Check the help menu for the text added in this patch

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize 2024-02-06 12:37:54 UTC
I decided in the end that you were probably right in the first place Matt, and that it could be a useful option to allow category only filtering.

In bug 34077 we add the category parameter to the initial check line, so maybe we just need that one instead of this.

I'll leave this open for now to get other opinions.
Comment 4 Nick Clemens (kidclamp) 2024-04-12 09:57:53 UTC
Created attachment 164820 [details] [review]
Bug 35996: Make it clear that --category-code can not be used alone

This patch adds a clarification to writeoff_debts.pl to make it clear that --category-code can't be used as the only filter when running the script. If this is the case, the script just displays the help menu as it is expecting one of the other filters

Test plan:
1) Run perl misc/cronjobs/writeoff_debts.pl --category-code TEST --confirm
2) Observe that the help menu is displayed instead of running the script
3) Check the help menu for the text added in this patch

WNC amended patch - added same warning in the option section

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Katrin Fischer 2024-04-29 07:44:02 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-24 09:26:08 UTC
Pushed to 23.11.x for 23.11.06
Comment 7 Lucas Gass 2024-05-28 20:45:09 UTC
Enhancement will not be backported to 23.05.x