koha_1 | Running: ERM/Agreements_spec.ts (3 of 13) es_1 | {"type": "server", "timestamp": "2024-02-06T16:59:14,821Z", "level": "WARN", "component": "o.e.c.r.a.DiskThresholdMonitor", "cluster.name": "docker-cluster", "node.name": "9c98971d8b48", "message": "high disk watermark [90%] exceeded on [ZlMDdHYSRcqipOaGsczI_w][9c98971d8b48][/usr/share/elasticsearch/data/nodes/0] free: 2.3gb[5.9%], shards will be relocated away from this node; currently relocating away shards totalling [0] bytes; the node is expected to continue to exceed the high disk watermark when these relocations are complete", "cluster.uuid": "wwW7XQ57T-SNI8QrMEYbPA", "node.id": "ZlMDdHYSRcqipOaGsczI_w" } koha_1 | <?xml version="1.0" encoding="UTF-8"?> koha_1 | <testsuites name="Mocha Tests" time="67.080" tests="5" failures="1"> koha_1 | <testsuite name="Root Suite" timestamp="2024-02-06T16:59:06" tests="0" file="t/cypress/integration/ERM/Agreements_spec.ts" time="0.000" failures="0"> koha_1 | </testsuite> koha_1 | <testsuite name="Agreement CRUD operations" timestamp="2024-02-06T16:59:06" tests="5" time="67.047" failures="1"> koha_1 | <testcase name="Agreement CRUD operations List agreements" time="0.000" classname="List agreements"> koha_1 | <failure message="Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 4th request to the route: `getActiveAgreements`. No request ever occurred. koha_1 | koha_1 | https://on.cypress.io/wait" type="CypressError"><![CDATA[CypressError: Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 4th request to the route: `getActiveAgreements`. No request ever occurred. koha_1 | koha_1 | https://on.cypress.io/wait koha_1 | at cypressErr (http://localhost:8081/__cypress/runner/cypress_runner.js:75187:18) koha_1 | at Object.errByPath (http://localhost:8081/__cypress/runner/cypress_runner.js:75242:10) koha_1 | at checkForXhr (http://localhost:8081/__cypress/runner/cypress_runner.js:134821:84) koha_1 | at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:134844:28) koha_1 | at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) koha_1 | at Promise.attempt.Promise.try (http://localhost:8081/__cypress/runner/cypress_runner.js:4315:29) koha_1 | at whenStable (http://localhost:8081/__cypress/runner/cypress_runner.js:143192:68) koha_1 | at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:143133:14) koha_1 | at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:1807:23) koha_1 | at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:1519:31) koha_1 | at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:1576:18) koha_1 | at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:1621:10) koha_1 | at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:1701:18) koha_1 | at Promise._fulfill (http://localhost:8081/__cypress/runner/cypress_runner.js:1645:18) koha_1 | at <unknown> (http://localhost:8081/__cypress/runner/cypress_runner.js:5450:46) koha_1 | From Your Spec Code: koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/ERM/Agreements_spec.ts:119:11)]]></failure> koha_1 | </testcase> koha_1 | <testcase name="Agreement CRUD operations Add agreement" time="30.510" classname="Add agreement"> koha_1 | </testcase> koha_1 | <testcase name="Agreement CRUD operations Edit agreement" time="6.377" classname="Edit agreement"> koha_1 | </testcase> koha_1 | <testcase name="Agreement CRUD operations Show agreement" time="4.285" classname="Show agreement"> koha_1 | </testcase> koha_1 | <testcase name="Agreement CRUD operations Delete agreement" time="8.038" classname="Delete agreement"> koha_1 | </testcase> koha_1 | </testsuite> koha_1 | </testsuites> I do not recreate locally, is it because we need to extend the timeout?
This was Koha_Master/2795 I scheduled another run (2796) and now it's InfiniteScrollSelect_spec that is getting a timeout koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | <?xml version="1.0" encoding="UTF-8"?> koha_1 | <testsuites name="Mocha Tests" time="32.874" tests="4" failures="1"> koha_1 | <testsuite name="Root Suite" timestamp="2024-02-07T09:33:33" tests="0" file="t/cypress/integration/InfiniteScrollSelect_spec.ts" time="0.000" failures="0"> koha_1 | </testsuite> koha_1 | <testsuite name="Infinite scroll" timestamp="2024-02-07T09:33:33" tests="4" time="32.851" failures="1"> koha_1 | <testcase name="Infinite scroll Should load the next page on scroll" time="6.352" classname="Should load the next page on scroll"> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly submit the form" time="0.000" classname="Should correctly submit the form"> koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find element: `main div[class='dialog message']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find element: `main div[class='dialog message']`, but never found it. koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/InfiniteScrollSelect_spec.ts:163:11)]]></failure> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly display labels" time="5.314" classname="Should correctly display labels"> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly display the label when editing" time="4.267" classname="Should correctly display the label when editing"> koha_1 | </testcase> koha_1 | </testsuite> koha_1 | </testsuites>
Maybe we do need to try upping the timeout - all tests are passing locally Can we set the Jenkins run to produce and save the cypress videos? That way we may be able to see if there's anything we're missing
For the record, #2797 is passing. (In reply to Matt Blenkinsop from comment #2) > Maybe we do need to try upping the timeout - all tests are passing locally Yes, but 10s is already a lot! :) > Can we set the Jenkins run to produce and save the cypress videos? That way > we may be able to see if there's anything we're missing The easiest would be IMO to connect to a node when it's running and run the cypress command manually. Otherwise you will need to adjust misc4dev, etc. Agreements failed on Docker_4 InfiniteScroll failed on Docker_15 and the last success build was on Docker_8
Koha_Master/2798 12:40:57 koha_1 | https://on.cypress.io/wait" type="CypressError"><![CDATA[CypressError: Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 1st request to the route: `getPageTwo`. No request ever occurred.
Again, Koha_Master/2799 koha_1 | Running: InfiniteScrollSelect_spec.ts (1 of 13) koha_1 | <?xml version="1.0" encoding="UTF-8"?> koha_1 | <testsuites name="Mocha Tests" time="37.336" tests="4" failures="2"> koha_1 | <testsuite name="Root Suite" timestamp="2024-02-14T14:36:05" tests="0" file="t/cypress/integration/InfiniteScrollSelect_spec.ts" time="0.000" failures="0"> koha_1 | </testsuite> koha_1 | <testsuite name="Infinite scroll" timestamp="2024-02-14T14:36:05" tests="4" time="37.316" failures="2"> koha_1 | <testcase name="Infinite scroll Should load the next page on scroll" time="5.922" classname="Should load the next page on scroll"> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly submit the form" time="0.000" classname="Should correctly submit the form"> koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find element: `main div[class='dialog message']`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find element: `main div[class='dialog message']`, but never found it. koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/InfiniteScrollSelect_spec.ts:163:11)]]></failure> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly display labels" time="0.000" classname="Should correctly display labels"> koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'License 50' within the element: <fieldset#agreement_license_0.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'License 50' within the element: <fieldset#agreement_license_0.rows> but never did. koha_1 | at Context.eval (webpack://koha/./t/cypress/integration/InfiniteScrollSelect_spec.ts:248:39)]]></failure> koha_1 | </testcase> koha_1 | <testcase name="Infinite scroll Should correctly display the label when editing" time="3.529" classname="Should correctly display the label when editing"> koha_1 | </testcase> koha_1 | </testsuite> koha_1 | </testsuites>
Both failures are in places where we aren't asking Cypress to wait for the result of a network response - I'm adding a patch that adds these in. We could use this as an experiment to see if it stops failures in the Infinite Scroll test. If it does then we could look to expand this to the other specs
Created attachment 162207 [details] [review] Bug 36012: Add 'waits' to cypress test This patch adds cy.wait() in two places where builds have been failing due to timeouts Test plan: 1) cypress run --spec t/cypress/integration/InfiniteScrollSelect_spec.ts
Koha_Master/2804 koha_1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'License 50' within the element: <fieldset#agreement_license_0.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'License 50' within the element: <fieldset#agreement_license_0.rows> but never did.
It looks like this just happened in our last run on Jenkins, it would be great to have a fix: https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/testReport/(root)/Should%20correctly%20display%20labels/Infinite_scroll_Should_correctly_display_labels/
(In reply to Katrin Fischer from comment #9) > It looks like this just happened in our last run on Jenkins, it would be > great to have a fix: > > https://jenkins.koha-community.org/job/Koha_Master/lastCompletedBuild/ > testReport/(root)/Should%20correctly%20display%20labels/ > Infinite_scroll_Should_correctly_display_labels/ Wrong link, but was the same problem as posted here previously.
I totally missed the patch here, because the status was still NEW. I've tested it locally and will push it to see if it fixes Jenkins.
Pushed for 24.05! Well done everyone, thank you!
Depends on Bug 32474 not in 23.11.x
Still failing (Koha_Master/2809) 17:04:34 koha_1 | <failure message="Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 1st request to the route: `resetDropdown`. No request ever occurred. 17:04:34 koha_1 | 17:04:34 koha_1 | https://on.cypress.io/wait" type="CypressError"><![CDATA[CypressError: Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 1st request to the route: `resetDropdown`. No request ever occurred.
Created attachment 163088 [details] [review] Bug 36012: Extend cypress's requestTimeout value default to 5000 but tests are failing because of slow Jenkins's nodes. We could try and extend to 10000 (10s) and see if it gets better.
(In reply to Jonathan Druart from comment #15) > Created attachment 163088 [details] [review] [review] > Bug 36012: Extend cypress's requestTimeout value > > default to 5000 but tests are failing because of slow Jenkins's nodes. > We could try and extend to 10000 (10s) and see if it gets better. Matt, do you agree with that?
Yes I think thats the best course of action now that adding the cy.wait hasn't fixed it
This is still in NEW, can you please clarify the status? Thanks!
Koha_Master/2819 (Docker_15) koha_1 | https://on.cypress.io/wait" type="CypressError"><![CDATA[CypressError: Timed out retrying after 5000ms: `cy.wait()` timed out waiting `5000ms` for the 1st request to the route: `get-single-agreement-search-result`. No request ever occurred.
Created attachment 163704 [details] [review] Bug 36012: Extend cypress's requestTimeout value default to 5000 but tests are failing because of slow Jenkins's nodes. We could try and extend to 10000 (10s) and see if it gets better. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Tests pass with and without the patch on my computer. Tested with: yarn cypress run --env KOHA_USER=koha,KOHA_PASS=koha \ --spec t/cypress/integration/ERM/Agreements_spec.ts
Matt agreed with this solution as well. PQA so we can check on Jenkins.