Bug 36017 - Dead code in admin/clone-rules
Summary: Dead code in admin/clone-rules
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 18936
Blocks: 34478
  Show dependency tree / graph
 
Reported: 2024-02-07 14:40 UTC by Jonathan Druart
Modified: 2024-03-11 08:44 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00
Circulation function:

Attachments
Bug 36017: Remove dead code in admin/clone-rules (4.30 KB, patch)
2024-02-07 14:43 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 36017: Remove dead code in admin/clone-rules (4.35 KB, patch)
2024-02-07 15:51 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 36017: Remove dead code in admin/clone-rules (4.41 KB, patch)
2024-02-08 18:50 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-02-07 14:40:41 UTC 
Since
  commit 61628c97c245e72c750b61d9df6fa9b9100f3093
  Bug 18936: (follow-up) Add cloning of circulation rules back to Koha

There are some dead code in admin/clone-rules.

"result" is always passed to the template.
Comment 1 Jonathan Druart 2024-02-07 14:43:38 UTC 
Created attachment 161809 [details] [review]
Bug 36017: Remove dead code in admin/clone-rules

Since
  commit 61628c97c245e72c750b61d9df6fa9b9100f3093
  Bug 18936: (follow-up) Add cloning of circulation rules back to Koha

There are some dead code in admin/clone-rules.

"result" is always passed to the template.

Test plan:
Confirm the above and that cloning rules from the circ rules page still
works correctly.
Comment 2 Owen Leonard 2024-02-07 15:51:31 UTC 
Created attachment 161818 [details] [review]
Bug 36017: Remove dead code in admin/clone-rules

Since
  commit 61628c97c245e72c750b61d9df6fa9b9100f3093
  Bug 18936: (follow-up) Add cloning of circulation rules back to Koha

There are some dead code in admin/clone-rules.

"result" is always passed to the template.

Test plan:
Confirm the above and that cloning rules from the circ rules page still
works correctly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Kyle M Hall (khall) 2024-02-08 18:50:00 UTC 
Created attachment 161950 [details] [review]
Bug 36017: Remove dead code in admin/clone-rules

Since
  commit 61628c97c245e72c750b61d9df6fa9b9100f3093
  Bug 18936: (follow-up) Add cloning of circulation rules back to Koha

There are some dead code in admin/clone-rules.

"result" is always passed to the template.

Test plan:
Confirm the above and that cloning rules from the circ rules page still
works correctly.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Jonathan Druart 2024-03-01 13:18:35 UTC 
Pushed to master for 24.05.00.
Comment 5 Fridolin Somers 2024-03-11 08:44:00 UTC 
Enhancement not pushed to 23.11.x