Bug 36074 - Make materials specified note easier to customize, part 2
Summary: Make materials specified note easier to customize, part 2
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 35253
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-12 22:02 UTC by Lucas Gass
Modified: 2024-05-28 21:36 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06


Attachments
Bug 36074: Add classes to materials specfied message on check in and checkout when CircConfirmItemParts is on. (2.95 KB, patch)
2024-02-12 22:05 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36074: Add classes to materials specfied message on check in and checkout when CircConfirmItemParts is on. (3.01 KB, patch)
2024-02-13 17:27 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-02-12 22:02:46 UTC
Bug 35253 made the materials specified note easier to customize. However I failed to realized that the message is slightly different if 'CircConfirmItemParts' is set to 'Require'.

That message should also include the HTML classes added for Bug 35253.
Comment 1 Lucas Gass 2024-02-12 22:05:20 UTC
Created attachment 162069 [details] [review]
Bug 36074: Add classes to materials specfied message on check in and checkout when CircConfirmItemParts is on.

To test:
1. APPLY PATCH
2. Set CircConfirmItemParts to 'Require'.
3. Add a materials specified message to an item. ( 952$3 )
4. Add the following CSS to your IntranetUserCSS:

    .mats_spec_label { color: white; background: purple;  }
    .mats_spec_message { color: white; background: green; }

5. Checkout that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple.
6. Check in that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple.
Comment 2 Brendan Lawlor 2024-02-13 17:27:35 UTC
Created attachment 162122 [details] [review]
Bug 36074: Add classes to materials specfied message on check in and checkout when CircConfirmItemParts is on.

To test:
1. APPLY PATCH
2. Set CircConfirmItemParts to 'Require'.
3. Add a materials specified message to an item. ( 952$3 )
4. Add the following CSS to your IntranetUserCSS:

    .mats_spec_label { color: white; background: purple;  }
    .mats_spec_message { color: white; background: green; }

5. Checkout that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple.
6. Check in that item. Notice the message should be green and the label (Note about the accompanying materials:) should be purple.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 3 Katrin Fischer 2024-05-06 07:47:59 UTC
Only adds CSS classes, reviewed closely.
Comment 4 Katrin Fischer 2024-05-06 07:55:07 UTC
(In reply to Katrin Fischer from comment #3)
> Only adds CSS classes, reviewed closely.

This was meant for another bug. Still only small mark-up changes here. 

Removed some additional spaces:
<span class="mats_spec_label"> Please confirm that the accompanying materials are present: </span>
Comment 5 Katrin Fischer 2024-05-06 09:18:53 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 6 Fridolin Somers 2024-05-24 13:39:46 UTC
I see one last additional space :
... are present:</span>
... are present: </span>
Removing it will allow to have online 1 translation :D
Comment 7 Fridolin Somers 2024-05-24 13:39:59 UTC
Pushed to 23.11.x for 23.11.06
Comment 8 Lucas Gass 2024-05-28 21:36:53 UTC
Enhancement will not be backported to 23.05.x