With the introduction in 23.11 moving the system preference, OPACResultsSideBar, to the Tools> HTML customization, it does not appear to be working with a library specific message. When creating a OPACresultsidebar to 'all libraries', this message does appear. Steps to reproduce: 1. Tools> HTML Customization 2. Choose OPACresultssidebar 3. Create an entry specific to a library. 4. Also try to add this same entry into a translation tab, if installed. 5. Go to the OPAC 6. Login as a patron of that library that the specific OPACresultsidebar is assigned to 7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear. 8. No text. Attempt to do this test plan, but creating a 'all libraries' entry will appear in the OPAC as expected.
Confirmed on current master
Created attachment 162628 [details] [review] Bug 36082: Set branchcode correctly in opac-facets.inc 1. Tools> HTML Customization 2. Choose OPACresultssidebar 3. Create an entry specific to a library. 4. Also try to add this same entry into a translation tab, if installed. 5. Go to the OPAC 6. Login as a patron of that library that the specific OPACresultsidebar is assigned to 7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear. 8. No text. 9. APPLY PATCH 10. Try step 7 again. 11. TEXT!
Created attachment 163015 [details] [review] Bug 36082: Set branchcode correctly in opac-facets.inc 1. Tools> HTML Customization 2. Choose OPACresultssidebar 3. Create an entry specific to a library. 4. Also try to add this same entry into a translation tab, if installed. 5. Go to the OPAC 6. Login as a patron of that library that the specific OPACresultsidebar is assigned to 7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear. 8. No text. 9. APPLY PATCH 10. Try step 7 again. 11. TEXT! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 164462 [details] [review] Bug 36082: Set branchcode correctly in opac-facets.inc 1. Tools> HTML Customization 2. Choose OPACresultssidebar 3. Create an entry specific to a library. 4. Also try to add this same entry into a translation tab, if installed. 5. Go to the OPAC 6. Login as a patron of that library that the specific OPACresultsidebar is assigned to 7. Search the catalog, and look below the facets,where the OPACresultssidebar would appear. 8. No text. 9. APPLY PATCH 10. Try step 7 again. 11. TEXT! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Not needed in 23.05.x, no backport.