The following notices need to be updated to use Template Toolkit syntax: DUE (email) DUE (sms) PREDUE (email) PREDUE (sms) These ones should be fairly straightforward. All four notices have nearly identical content, so it makes sense to group them together.
I am assuming will be retain the ability to use <<item.content>> ?
Yup, this is just about updating the default notice text (and making sure the notices support the item content via TT if they don't already), not deprecating <<items.content>> on the back end.
(In reply to Emily Lamancusa from comment #2) > Yup, this is just about updating the default notice text (and making sure > the notices support the item content via TT if they don't already), not > deprecating <<items.content>> on the back end. Great! Thanks, Emily!
Created attachment 165591 [details] [review] Bug 36106: Adjust DUE and PREDUE notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Leave Digests only unchecked Advance notice - Select 1 day in advance - Check SMS - Check Email - Leave Digests only unchecked 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out an item 7. Set a custom due date for tomorrow and check out another item 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct
Created attachment 166415 [details] [review] Bug 36106: Adjust DUE and PREDUE notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Enable SMS Notices a) Find the system preference SMSSendDriver b) Enter "Email" as the value for SMSSendDriver and save 4. Go to a patron account, and set the following messaging preferences: Item due: - Check SMS - Check Email - Leave Digests only unchecked Advance notice - Select 1 day in advance - Check SMS - Check Email - Leave Digests only unchecked 5. Go to the checkout tab for that patron 6. Set a custom due date for today and check out an item 7. Set a custom due date for tomorrow and check out another item 8. Run the cron job to generate notices: misc/cronjobs/advance_notices.pl -v -c 9. Open the Notices tab on that patron's account --> The patron should have four notices: Item due reminder (one for SMS and one for email) Advance notice of item due (one for SMS and one for email) 10. Open each notice and confirm that all information is correct Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great work, thanks Emily. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x