36113 – Port default RENEWAL notice to Template Toolkit syntax

Bug 36113 - Port default RENEWAL notice to Template Toolkit syntax

Summary: Port default RENEWAL notice to Template Toolkit syntax

Status:	Needs documenting

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Notices (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Emily Lamancusa (emlam)
QA Contact:	Martin Renvoize (ashimema)

URL:
Keywords:	Academy, roadmap_24_05

Depends on:
Blocks:	15278
	Show dependency tree / graph

Reported:	2024-02-15 22:02 UTC by Emily Lamancusa (emlam)
Modified:	2024-11-08 14:30 UTC (History)
CC List:	1 user (show)

See Also:
Change sponsored?:	---
Patch complexity:	String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	The default notice template for the RENEWAL notification now uses modern Template Toolkit rather than the old custom syntax. This will only affect new installations, unless the library chooses to reset their notices to the default.
Version(s) released in:	24.05.00
Circulation function:

Attachments
Bug 36113: Adjust default RENEWAL notice template to use TT (1.49 KB, patch) 2024-04-15 21:36 UTC, Emily Lamancusa (emlam)	Details \| Diff \| Splinter Review
Bug 36113: Adjust default RENEWAL notice template to use TT (1.57 KB, patch) 2024-04-18 10:22 UTC, Matt Blenkinsop	Details \| Diff \| Splinter Review
Bug 36113: Adjust default RENEWAL notice template to use TT (1.62 KB, patch) 2024-05-08 13:14 UTC, Martin Renvoize (ashimema)	Details \| Diff \| Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Emily Lamancusa (emlam) 2024-02-15 22:02:04 UTC

Comment 1 Emily Lamancusa (emlam) 2024-04-15 21:36:15 UTC

Created attachment 164896 [details] [review]
Bug 36113: Adjust default RENEWAL notice template to use TT

Test plan:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable the system preference RenewalSendNotice
4. Check an item out to a patron
5. Edit that patron:
    a. Enter a value for Primary email
    b. Set messaging preference to enable email notices for Item
       checkout and renewal
6. Renew the checked-out item
7. Check the patron's Notices tab for the Item renewal notice, and
   confirm that the notice is correct

Comment 2 Matt Blenkinsop 2024-04-18 10:22:41 UTC

Created attachment 165069 [details] [review]
Bug 36113: Adjust default RENEWAL notice template to use TT

Test plan:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable the system preference RenewalSendNotice
4. Check an item out to a patron
5. Edit that patron:
    a. Enter a value for Primary email
    b. Set messaging preference to enable email notices for Item
       checkout and renewal
6. Renew the checked-out item
7. Check the patron's Notices tab for the Item renewal notice, and
   confirm that the notice is correct

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Comment 3 Martin Renvoize (ashimema) 2024-05-08 13:14:18 UTC

Created attachment 166411 [details] [review]
Bug 36113: Adjust default RENEWAL notice template to use TT

Test plan:
1. Apply patch
2. reset_all (or start your testing environment in the first place)
3. Enable the system preference RenewalSendNotice
4. Check an item out to a patron
5. Edit that patron:
    a. Enter a value for Primary email
    b. Set messaging preference to enable email notices for Item
       checkout and renewal
6. Renew the checked-out item
7. Check the patron's Notices tab for the Item renewal notice, and
   confirm that the notice is correct

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Comment 4 Katrin Fischer 2024-05-10 12:33:28 UTC

This one is pretty basic and uses a different "signature" than others. Might also be something that could get prettified a little bit :)

Maybe everytime we curerntly use biblio.title it would be worthwhile to use our include for the nice title display instead, that also pulls subject, parts etc.

Comment 5 Martin Renvoize (ashimema) 2024-05-10 12:57:23 UTC

I did wonder about using nice includes for display yes.. but I also didn't want to get stuck in the weeds of new wording...

Comment 6 Martin Renvoize (ashimema) 2024-05-10 12:58:57 UTC

It's also not marked as HTML.. and our include helpers are generally designed for HTML output.. so we'd likely want to upgrade it to HTML at the same time ;P

Comment 7 Katrin Fischer 2024-05-10 13:20:06 UTC

Pushed for 24.05!

Well done everyone, thank you!

Comment 8 Fridolin Somers 2024-05-29 08:46:30 UTC

Not backported to 23.11.x